From c3775f9d7a4b01f1022be2486a2409716faf9e3e Mon Sep 17 00:00:00 2001 From: Michael Bleigh Date: Tue, 4 Feb 2025 12:41:43 -0800 Subject: [PATCH] chore(js): remove extraneous console.log statements (#1829) --- js/ai/src/generate/resolve-tool-requests.ts | 7 ++----- js/core/src/tracing/processor.ts | 4 ---- js/plugins/langchain/src/tracing.ts | 6 ------ js/plugins/mcp/src/server.ts | 1 - 4 files changed, 2 insertions(+), 16 deletions(-) diff --git a/js/ai/src/generate/resolve-tool-requests.ts b/js/ai/src/generate/resolve-tool-requests.ts index f87c6495b..3fb294f8e 100644 --- a/js/ai/src/generate/resolve-tool-requests.ts +++ b/js/ai/src/generate/resolve-tool-requests.ts @@ -337,7 +337,6 @@ export async function resolveResumeOption( interruptedResponse?: GenerateResponseData; }> { if (!rawRequest.resume) return { revisedRequest: rawRequest }; // no-op if no resume option - console.log('RESOLVE RESUME OPTION:', rawRequest.resume); const toolMap = toToolMap(await resolveTools(registry, rawRequest.tools)); const messages = rawRequest.messages; @@ -346,11 +345,11 @@ export async function resolveResumeOption( if ( !lastMessage || lastMessage.role !== 'model' || - !lastMessage.content.find((p) => p.toolRequest && p.metadata?.interrupt) + !lastMessage.content.find((p) => p.toolRequest) ) { throw new GenkitError({ status: 'FAILED_PRECONDITION', - message: `Cannot 'resume' generation unless the previous message is a model message with at least one interrupt.`, + message: `Cannot 'resume' generation unless the previous message is a model message with at least one tool request.`, }); } @@ -365,7 +364,6 @@ export async function resolveResumeOption( part, toolMap ); - console.log('RESOLVED TOOL', part.toolRequest.name, 'TO', resolved); if (resolved.interrupt) { interrupted = true; return resolved.interrupt; @@ -407,7 +405,6 @@ export async function resolveResumeOption( }, }; - console.log('CONSTRUCTED A TOOL MESSAGE:', toolMessage.content); return stripUndefinedProps({ revisedRequest: { ...rawRequest, diff --git a/js/core/src/tracing/processor.ts b/js/core/src/tracing/processor.ts index 73ccfebdb..6cb8c5752 100644 --- a/js/core/src/tracing/processor.ts +++ b/js/core/src/tracing/processor.ts @@ -72,10 +72,6 @@ class FilteringReadableSpanProxy implements ReadableSpan { return this.span.status; } get attributes() { - console.log( - 'FilteringReadableSpanProxy get attributes', - this.span.attributes - ); const out = {} as Record; for (const [key, value] of Object.entries(this.span.attributes)) { if (!key.startsWith(ATTR_PREFIX + ':')) { diff --git a/js/plugins/langchain/src/tracing.ts b/js/plugins/langchain/src/tracing.ts index 0c47cce76..1592e5e1e 100644 --- a/js/plugins/langchain/src/tracing.ts +++ b/js/plugins/langchain/src/tracing.ts @@ -62,13 +62,7 @@ export class GenkitTracer extends BaseTracer { ctx = trace.setSpan(context.active(), parentCtx); } const span = this.tracer.startSpan(run.name, undefined, ctx); - console.log('run', JSON.stringify(run, undefined, ' ')); if (run.inputs) { - console.log('setting inputs', run.inputs); - console.log( - 'setting inputs flattened', - this.maybeFlattenInput(run.inputs) - ); span.setAttribute( 'genkit:input', JSON.stringify(this.maybeFlattenInput(run.inputs)) diff --git a/js/plugins/mcp/src/server.ts b/js/plugins/mcp/src/server.ts index 5fdfd8fc9..55599f617 100644 --- a/js/plugins/mcp/src/server.ts +++ b/js/plugins/mcp/src/server.ts @@ -99,7 +99,6 @@ export class GenkitMcpServer { const toolList: ToolAction[] = []; const promptList: PromptAction[] = []; for (const k in allActions) { - console.log('action:', k); if (k.startsWith('/tool/')) { toolList.push(allActions[k] as ToolAction); } else if (k.startsWith('/prompt/')) {