Skip to content

Commit 8944ede

Browse files
CodingDougsamtstern
authored andcommitted
Be clear more clear about results of enablePersistence() (#9)
The code sample here suggests that the developer should use the promise returned from enablePersistence() to get a hold of a new Firestore instance when the promise resolves successfully. This isn't a requirement, as subsequent queries are supposed to be enqueued to execute after enablePersistence is complete, in either success or failure cases.
1 parent cc9b15b commit 8944ede

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

firestore/test.firestore.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ describe("firestore", () => {
2424
);
2525

2626
firebase.firestore().enablePersistence()
27-
.then(function() {
28-
// Initialize Cloud Firestore through firebase
29-
var db = firebase.firestore();
30-
})
3127
.catch(function(err) {
3228
if (err.code == 'failed-precondition') {
3329
// Multiple tabs open, persistence can only be enabled
@@ -39,6 +35,7 @@ describe("firestore", () => {
3935
// ...
4036
}
4137
});
38+
// Subsequent queries will use persistence, if it was enabled successfully
4239
// [END initialize_persistence]
4340
});
4441

0 commit comments

Comments
 (0)