Skip to content

Commit e5cd857

Browse files
Remove create task stdin/stdout/stderr fields. (#781)
Stdin/stdout/stderr fields can container full shim logger binary URIs which may container sensitive information such as logging credentials. Since there is no simple method for redacting this information at runtime, the best solution is to not log them to disk. Signed-off-by: Austin Vazquez <[email protected]>
1 parent 3fae0bd commit e5cd857

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

runtime/service.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1146,12 +1146,10 @@ func (s *service) Create(requestCtx context.Context, request *taskAPI.CreateTask
11461146
return nil, err
11471147
}
11481148

1149+
// We don't log request.Stdin, request.Stdout, or request.Stderr as they may contain sensitive information.
11491150
logger.WithFields(logrus.Fields{
11501151
"bundle": request.Bundle,
11511152
"terminal": request.Terminal,
1152-
"stdin": request.Stdin,
1153-
"stdout": request.Stdout,
1154-
"stderr": request.Stderr,
11551153
"checkpoint": request.Checkpoint,
11561154
}).Debug("creating task")
11571155

0 commit comments

Comments
 (0)