From 61de82b98870412a15636f8b0db34a73510fdd25 Mon Sep 17 00:00:00 2001 From: Erik Engervall Date: Mon, 21 Sep 2026 19:19:09 +0900 Subject: [PATCH] Run the docs checks on pushes to main The checks ran on pull requests only. The translation sync commits straight to main, so a translated API identifier that lands there fails the locale check on the next unrelated pull request while main itself shows nothing. Running the same job on pushes to main makes the failure visible where it happens. --- .github/workflows/checks.yml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 1677a1758..ad7585e88 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -1,10 +1,16 @@ name: Docs checks -# No `branches` filter. A stacked pull request targets the branch of the pull -# request below it, not main, so a `branches: [main]` filter would skip every -# stacked change and only run on the last one in a stack. +# No `branches` filter on pull requests. A stacked pull request targets the +# branch of the pull request below it, not main, so a `branches: [main]` filter +# would skip every stacked change and only run on the last one in a stack. +# +# Also on pushes to main: the translation sync commits straight to main, so a +# translated identifier that lands there would otherwise show up only on the +# next unrelated pull request. Running here makes main red when main is red. on: pull_request: + push: + branches: [main] # Read-only. This workflow runs code from the pull request branch, so it is # `pull_request` rather than `pull_request_target` and it is given no write @@ -21,7 +27,7 @@ jobs: name: Locale literals and extraction-hostile markdown runs-on: ubuntu-latest steps: - - name: Check out the pull request branch + - name: Check out the branch uses: actions/checkout@v4 - name: Set up Node 22