-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation - packing list #260
Comments
Correct, what is the issue? |
I think the issue is that most shops use this PDF as a packing slip. "Shipment" is a weird title. In any case, I think we should stick to Magento's default title. The default title is indeed "Packzettel" in German (I did not check in English, but it is most likely packing slip). |
@sprankhub - that is what I meant. I think the label should be packing slip and not shipment. |
Alright, this is implemented now. Thanks for bringing that up @Mr-Jingles! @Schrank should we also change the default filename of the downloaded PDFs from shipment* to packingslip*? I think this would be consequent. |
Our shop owner said "Packzettel" is not what it should be (not saying "illegal" as I am no lawyer and didnt have anything in writing to back me up). He said it should be "Lieferschein". Should we fix this by overwriting this in a CSV or fix it again in PHP ? @sprankhub |
I have no clue what is right here. I think just putting it into translate.csv fixes the problem for you. And about the question of @sprankhub: Ich would change the default. |
I am not sure if there are legal requirements for packingslips. I decided to use "Packzettel", because this translation is also used in the DE community translation: https://github.com/riconeitzel/German_LocalePack_de_DE/blob/8249c5856c001ac9a9cf1b35a6764d41c0450c2e/app/locale/de_DE/Mage_Sales.csv#L488 I think IF this is changed, it should be changed in both projects... |
http://forum.azmagento.com/how-to/lieferschein-vs-packzettel-63-nbsp--39851.html#forumcm
https://de.wikipedia.org/wiki/Pickzettel Pickzettel/Packzettel verstehe ich in dem Zusammenhang also anders, als einen Lieferschein, den Magento dir ja ausdruckt. (Sorry for german, but I think this just concerns german speaking users) |
I also think that "Lieferschein" is better, but I would like to stick to the community translation. @riconeitzel what do you think - can we change the wording in both projects? That would be the best solution imho. |
Yes, I once had "lieferschein" but I don't remember why I changed it again.
|
@riconeitzel would you agree that "Lieferschein" is more reasonable than "Packzettel"? Can we change it in both projects? |
@riconeitzel bump ;-) |
@riconeitzel don't overlook this. |
Currently the packing list is translated as "Shipment". I am referring to line 483 in Abstract.php
} elseif ($mode == 'shipment') {
$title = 'Shipment';
} else {
The text was updated successfully, but these errors were encountered: