Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating a ci pipeline into the project #27

Open
alexprodan99 opened this issue Aug 17, 2022 · 5 comments
Open

Integrating a ci pipeline into the project #27

alexprodan99 opened this issue Aug 17, 2022 · 5 comments

Comments

@alexprodan99
Copy link

What about integrating a ci pipeline into the project?
In this way, we could automate the process of checking that the new changes are breaking the codebase or not.
I think that a Github Actions pipeline would fit well here.

@b0iq
Copy link
Contributor

b0iq commented Aug 17, 2022

I agree, and for the testing ci I think there's some errors with playwright for testing, since I don't know a lot of playwright but I tried to run the tests locally but I keep getting all tests failed without any changing from the main branch.

@ekwoka
Copy link
Contributor

ekwoka commented Aug 17, 2022

@b0iq Are you running the example site?

It's quite annoying currently, for me it was 3 terminals, one running the liveserver, one watching to build the package, and one that was running the tests when the package changed 😤

@b0iq
Copy link
Contributor

b0iq commented Aug 17, 2022

@ekwoka

Yeah, me too, I'm running three terminals just like you and I did install playwright but it keeps failing 🤬

@dhirajgagrai
Copy link
Contributor

@b0iq Which of the tests are failing for you?

@micziz
Copy link

micziz commented Aug 27, 2022

Test cloud be easily automated. Even running the example site (even tough I think leerobs pr to add vercel should have done it?) Anyways: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants