Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support FAL target.type #60

Open
1 of 4 tasks
fivetran-joemarkiewicz opened this issue Dec 5, 2022 · 0 comments
Open
1 of 4 tasks

[Feature] Support FAL target.type #60

fivetran-joemarkiewicz opened this issue Dec 5, 2022 · 0 comments
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@fivetran-joemarkiewicz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

As identified within the dbt_stripe Issue #45, it seems that the fal target.type is not supported within conditionals found throughout the package. In particular, the get_plan_columns conditional is exclusively looking for the target.type in BigQuery, Spark, or Databricks. However, if a user has the fal adapter, then it will fail as the quoting is needed but the adapter is not included in the conditional.

This feature is to explore supporting the fal adapter and how it differs from other warehouses.

Describe alternatives you've considered

Do not use the fal adapter.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-joemarkiewicz fivetran-joemarkiewicz added type:enhancement New functionality or enhancement priority:p4 Affects few users; pick up when available update_type:feature Primary focus is to add new functionality labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

1 participant