Skip to content

export of pruned lineages doesn't indicate pruning #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julou opened this issue Mar 17, 2017 · 1 comment
Open

export of pruned lineages doesn't indicate pruning #35

julou opened this issue Mar 17, 2017 · 1 comment
Labels

Comments

@julou
Copy link
Collaborator

julou commented Mar 17, 2017

Hello,

We are trying to make a more extensive use of pruning to detect some cell lysis events…
Doing so, I realised that the end_type variable of a pruned lineage is set by what happens downstream of pruning (one of exit / div / eod). I think that the general behaviour should be to set the end_type to "pruned".

Thanks!

@julou julou added the bug label May 1, 2017
@julou
Copy link
Collaborator Author

julou commented May 6, 2017

this has stronger implications that I initially thought:
in most analysis with this type of data (including previous papers by other labs not using MoMA), one focuses on cells that have been tracked from birth to division (mostly to discard cells that exit before dividing). The easy way to do this is to filter cells not born at time 0 and with end_type == 'div'.

Due to this bug, the second criteria is not matched since a cells that is pruned an divide between the pruning point and its exit will be marked as end_type == 'div' although it's not tracked until division…

So it is important fix not to mislead users in their downstream analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant