Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make offset prop a flexible unit #40

Open
HemalR opened this issue Jan 24, 2019 · 2 comments
Open

Make offset prop a flexible unit #40

HemalR opened this issue Jan 24, 2019 · 2 comments

Comments

@HemalR
Copy link

HemalR commented Jan 24, 2019

It would be very useful for responsive design to have the offset prop be a string which would allow units to be flexible. I.e. - Instead of specifying the px height we could specify e.g. a vh unit, or rems or whatever...

Thoughts/workaround?
@fkhadra
Copy link
Owner

fkhadra commented Jan 25, 2019

Hello,

Indeed sounds like a good idea. Do you want to make a PR for this ?

@HemalR
Copy link
Author

HemalR commented Feb 4, 2019

Noobie dev who doesn't know how to do a PR 😬

Perfect time to learn I guess. I'll give it a whack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkhadra @HemalR