Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not skip duplicate runs after a merge_group trigger #340

Open
haugene opened this issue Mar 8, 2024 · 0 comments
Open

Does not skip duplicate runs after a merge_group trigger #340

haugene opened this issue Mar 8, 2024 · 0 comments

Comments

@haugene
Copy link

haugene commented Mar 8, 2024

We're seeing consistent duplicate runs when the first run was done as part of a merge_group. The skip-duplicate action is outputting: Do not skip execution because we did not find a transferable run even if the exact same commit hash have already succeeded as part of a group and is now merged to main in our repo.

I suspect that the workflow filter implemented here is causing duplicate runs to pass the check when the first run was executed as part of a merge_group.

if (run.id !== currentRun.id && run.head_commit) {

The GitHub trigger docs show that a merge_group trigger does not have a head_commit but instead has a merge_group.head_commit.

I'm not too familiar with TypeScript and how fields are mapped here. But could we add another check here to include runs that have merge_group.head_commit present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant