Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pickle classes & plugins in modelcard #3325

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

helpmefindaname
Copy link
Collaborator

No description provided.

@helpmefindaname helpmefindaname linked an issue Oct 2, 2023 that may be closed by this pull request
@helpmefindaname helpmefindaname changed the title 3312 bug loading model with own trainerplugin don't pickle classes & plugins in modelcard Oct 2, 2023
@helpmefindaname helpmefindaname marked this pull request as ready for review October 9, 2023 13:11
@alanakbik
Copy link
Collaborator

Looks good! Thanks for fixing this @helpmefindaname!

@alanakbik alanakbik merged commit 41b2ad4 into master Oct 10, 2023
1 check passed
@alanakbik alanakbik deleted the 3312-bug-loading-model-with-own-trainerplugin branch October 10, 2023 23:11
@stefan-it
Copy link
Member

stefan-it commented Oct 13, 2023

Thanks for fixing that!

I really like this new plugins interface 🤗

I think a nice plugin code also be for carbon emission tracking with codecarbon as it is currently done in Transformers (see here) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Loading Model with own TrainerPlugin
3 participants