Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Json serialization inquiries #702

Open
ruggsea opened this issue Feb 5, 2025 · 1 comment
Open

[Question]: Json serialization inquiries #702

ruggsea opened this issue Feb 5, 2025 · 1 comment
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ruggsea
Copy link
Contributor

ruggsea commented Feb 5, 2025

Question

Is there a particular reason for why when saving articles to json (for example by specifying save_to_file in the crawling or by using the Article.to_json() method) things like the URL of the articles and/or the specific publisher the articles came from are not included? Or maybe they are and I am being mistaken?

In any case, I was also wondering if the Image attribute is also already supported in the serialization, because I've got some errors when trying to serialize articles containing that attribute (but I am not filing it as a bug cause I am not sure whether it was a mistake in my devel env)

@ruggsea ruggsea added the question Further information is requested label Feb 5, 2025
@MaxDall MaxDall self-assigned this Feb 5, 2025
@MaxDall MaxDall added the bug Something isn't working label Feb 5, 2025
@MaxDall
Copy link
Collaborator

MaxDall commented Feb 5, 2025

@ruggsea Thanks for catching that. While the Image object is serializable, we missed a bug in the articles' to_json method causing these issues. I will work on a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants