Skip to content

Commit 122533a

Browse files
committed
problems
1 parent 65fb07e commit 122533a

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

packages/flame/lib/src/extensions/matrix4.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ extension Matrix4Extension on Matrix4 {
8080
return transform2(out);
8181
}
8282

83-
Float64List get storage64 => Float64List.sublistView(storage);
83+
Float64List get storage64 => Float64List.fromList(storage);
8484

8585
/// Create a scaled matrix.
8686
///

packages/flame/test/game/transform2d_test.dart

+11-9
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void main() {
4545

4646
t.position.setFrom(Vector2(7, 2.2));
4747
expect(t.x, 7);
48-
expect(t.y, 2.2);
48+
expect(t.y, closeTo(2.2, _epsilon));
4949
expect(notified, 4);
5050

5151
t.position.setZero();
@@ -93,12 +93,12 @@ void main() {
9393
test('angle', () {
9494
final t = Transform2D();
9595
t.angle = tau / 6;
96-
expect(t.angleDegrees, closeTo(60, 1e-10));
96+
expect(t.angleDegrees, closeTo(60, 10e-6));
9797
t.angleDegrees = 45;
98-
expect(t.angle, closeTo(tau / 8, 1e-10));
98+
expect(t.angle, closeTo(tau / 8, 10e-6));
9999
t.angle = 1;
100100
expect(t.angle, 1);
101-
expect(t.angleDegrees, closeTo(360 / tau, 1e-10));
101+
expect(t.angleDegrees, closeTo(360 / tau, 10e-6));
102102
});
103103

104104
test('.closeTo', () {
@@ -173,16 +173,16 @@ void main() {
173173
for (var k = 0; k < 16; k++) {
174174
expect(
175175
transform2d.transformMatrix.storage[k],
176-
closeTo(matrix4.storage[k], 1e-10),
176+
closeTo(matrix4.storage[k], 10e-6),
177177
);
178178
}
179179
// Check round-trip conversion between local and global
180180
final point1 =
181181
Vector2((rnd.nextDouble() - 0.5) * 5, (rnd.nextDouble() - 0.5) * 5);
182182
final point2 =
183183
transform2d.globalToLocal(transform2d.localToGlobal(point1));
184-
expect(point1.x, closeTo(point2.x, 1e-10));
185-
expect(point1.y, closeTo(point2.y, 1e-10));
184+
expect(point1.x, closeTo(point2.x, 10e-6));
185+
expect(point1.y, closeTo(point2.y, 10e-6));
186186
}
187187
});
188188

@@ -194,12 +194,14 @@ void main() {
194194
expect(t.globalToLocal(point), Vector2(0, 0));
195195

196196
t.angleDegrees = 60;
197-
expect(t.localToGlobal(point).x, closeTo(1 / 2, 1e-10));
198-
expect(t.localToGlobal(point).y, closeTo(math.sqrt(3) / 2, 1e-10));
197+
expect(t.localToGlobal(point).x, closeTo(1 / 2, 10e-6));
198+
expect(t.localToGlobal(point).y, closeTo(math.sqrt(3) / 2, 10e-6));
199199
expect(t.globalToLocal(point), Vector2(0, 0));
200200

201201
t.scale = Vector2(0, 1);
202202
expect(t.globalToLocal(point), Vector2(0, 0));
203203
});
204204
});
205205
}
206+
207+
const _epsilon = 10e-6;

0 commit comments

Comments
 (0)