comments

Author: avalonche

crates/op-rbuilder/src/flashtestations/builder_tx.rs

@@ -245,10 +245,10 @@ impl FlashtestationsBuilderTx {
                 revert_reason: None,
                 logs,
             }),
-            ExecutionResult::Revert { output, .. } => {
+            ExecutionResult::Revert { output, gas_used} => {
                 let revert_reason = FlashtestationRegistryError::from(output);
                 Ok(TxSimulateResult {
-                    gas_used: 0,
+                    gas_used,
                     success: false,
                     state_changes: state,
                     revert_reason: Some(FlashtestationRevertReason::FlashtestationRegistry(
@@ -317,10 +317,10 @@ impl FlashtestationsBuilderTx {
                 revert_reason: None,
                 logs,
             }),
-            ExecutionResult::Revert { output, .. } => {
+            ExecutionResult::Revert { output, gas_used} => {
                 let revert_reason = BlockBuilderPolicyError::from(output);
                 Ok(TxSimulateResult {
-                    gas_used: 0,
+                    gas_used,
                     success: false,
                     state_changes: state,
                     revert_reason: Some(FlashtestationRevertReason::BlockBuilderPolicy(

crates/op-rbuilder/src/flashtestations/tx_manager.rs

@@ -19,7 +19,7 @@ use crate::{flashtestations::IFlashtestationRegistry, tx_signer::Signer};
 #[derive(Debug, thiserror::Error)]
 pub enum TxManagerError {
     #[error("rpc error: {0}")]
-    RpcError(TransportError),
+    RpcError(#[from] TransportError),
     #[error("tx reverted: {0}")]
     TxReverted(TxHash),
     #[error("error checking tx confirmation: {0}")]
@@ -30,12 +30,6 @@ pub enum TxManagerError {
     SignerError(ecdsa::Error),
 }
 
-impl From<TransportError> for TxManagerError {
-    fn from(e: TransportError) -> Self {
-        TxManagerError::RpcError(e)
-    }
-}
-
 #[derive(Debug, Clone)]
 pub struct TxManager {
     tee_service_signer: Signer,