[BUG] Filtering with wild card values not possible

[slackfan]

Service

EC2

AWS API Action

describe-vpcs

Expected behavior

When filtering for tag values using wildcards is supported as it is with the real API.

Actual behavior

When filtering for tag values using wild cards is unsupported. It seems the wildcards are taken as is.

Reproduction

aws --endpoint-url=http://floci:4566 \
    ec2 create-vpc \
    --cidr-block 10.0.0.0/16 \
    --tag-specifications ResourceType=vpc,Tags=[{Key=Name,Value=BEGINANDEND}]
{
    "Vpc": {
        "OwnerId": "000000000000",
        "InstanceTenancy": "default",
        "CidrBlockAssociationSet": [
            {
                "AssociationId": "vpc-cidr-assoc-a0d1592c",
                "CidrBlock": "10.0.0.0/16",
                "CidrBlockState": {
                    "State": "associated"
                }
            }
        ],
        "IsDefault": false,
        "Tags": [
            {
                "Key": "Name",
                "Value": "BEGINANDEND"
            }
        ],
        "VpcId": "vpc-8c2e8fdd",
        "State": "available",
        "CidrBlock": "10.0.0.0/16",
        "DhcpOptionsId": "dopt-default"
    }
}

aws --endpoint-url=http://floci:4566 \
    ec2 describe-vpcs \
    --filters 'Name=tag:Name,Values=BEGINANDEND'
{
    "Vpcs": [
        {
            "OwnerId": "000000000000",
            "InstanceTenancy": "default",
            "CidrBlockAssociationSet": [
                {
                    "AssociationId": "vpc-cidr-assoc-a0d1592c",
                    "CidrBlock": "10.0.0.0/16",
                    "CidrBlockState": {
                        "State": "associated"
                    }
                }
            ],
            "IsDefault": false,
            "Tags": [
                {
                    "Key": "Name",
                    "Value": "BEGINANDEND"
                }
            ],
            "VpcId": "vpc-8c2e8fdd",
            "State": "available",
            "CidrBlock": "10.0.0.0/16",
            "DhcpOptionsId": "dopt-default"
        }
    ]
}

aws --endpoint-url=http://floci:4566 \
    ec2 describe-vpcs \
    --filters 'Name=tag:Name,Values=BEGIN*END'
{
    "Vpcs": []
}

Environment

• Floci 1.5.15
• boto3 1.43.6, awscli 2.32.7
• Floci is running in Docker

[slackfan]

For comparison I guess https://github.com/ministackorg/ministack/blob/main/ministack/services/ec2.py#L2517 vs https://github.com/floci-io/floci/blob/main/src/main/java/io/github/hectorvent/floci/services/ec2/Ec2Service.java#L1232

[slackfan]

Something like that could work maybe. I have no proper dev-setup for this at the moment unfortunately.

    private String wildCardsToRegex(String value) {
        String result = "^";
        for (int index = 0; index < value.length(); ++index) {
            final char character = value.charAt(index);
            switch (character) {
                case '*': result += ".*";
                    break;
                case '?': result += ".";
                    break;
                case '.': result += "\\.";
                    break;
                case '\\': result += "\\\\";
                    break;
                default: result += character;
            }
        }
        result += "$";
        return result;
    }

    private boolean matchesValue(List<String> matchers, String value) {
        return matchers.stream().anyMatch(f -> value.matches(wildCardsToRegex(f)));
    }

    private boolean matchesFilter(Object resource, String filterName, List<String> values, String region) {
        if (filterName.startsWith("tag:")) {
            String tagKey = filterName.substring(4);
            List<Tag> resourceTags = getResourceTags(resource);
            return resourceTags.stream()
                    .anyMatch(t -> t.getKey().equals(tagKey) && matchesValue(values, t.getValue()));
        }
        if ("tag-key".equals(filterName)) {
            List<Tag> resourceTags = getResourceTags(resource);
            return resourceTags.stream().anyMatch(t -> matchesValue(values, t.getKey()));
        }
        if ("tag-value".equals(filterName)) {
            List<Tag> resourceTags = getResourceTags(resource);
            return resourceTags.stream().anyMatch(t -> matchesValue(values, t.getValue()));
        }
   ...

[hectorvent]

Hi @slackfan,

Thanks for the report and all the context.

[kapoorp99]

@hectorvent
I have worked on this issue and opened the PR
#837