Improvements for decimal_class: BigDecimal
#526
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is excellent that it is so easy to preserve arbitrary numeric precision parsing JSON with
decimal_class: BigDecimal
. This currently has a couple of deficiencies, though.This PR adds documentation where missing, and changes the generation to be a number, as seems much more natural.
I also split
json_addition_test.rb
to its own run becauserequire 'json/add/bigdecimal'
would overrideBigDecimal#to_json
.