Always dup argument to preserve original encoding for force_encoding #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
byroot
force-pushed
the
feature/stop-changing-original-encoding
branch
from
9db2b4e
to
1d99922
Compare
byroot
force-pushed
the
feature/stop-changing-original-encoding
branch
from
1d99922
to
db9a489
Compare
|
Thanks. I rebased your PR and also added the Java version of the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #529.
In order to avoid changing original encoding,
this patch always dups argument for
ASCII-8BITencoding.I have also added a test
test_argument_encoding_for_binary.The structure is following
test_argument_encoding.Considering the following facts, IMHO, I believe this patch meets the original intention of this gem.
JSON::Pure::Parser.new(str)does not change the encoding of original argument forASCII-8BITASCII-8BITencodings.