Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON::Pure fix strict mode #585

Merged
merged 1 commit into from
Oct 8, 2024
Merged

JSON::Pure fix strict mode #585

merged 1 commit into from
Oct 8, 2024

Conversation

casperisfine
Copy link

Followup: #519
Fix: #584

@casperisfine casperisfine mentioned this pull request May 9, 2024
Closed
eregon
eregon reviewed May 9, 2024
View reviewed changes
lib/json/pure/generator.rb Outdated Show resolved Hide resolved
@eregon
Copy link
Member

eregon commented May 9, 2024

I also noticed the docs in https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L222 are wrong, could you fix that too?

And the alignment in https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L143 is inconsistent (I dislike this kind of alignment, too high maintenance and diff noise, but might as well be consistent in one way, i.e. all or none aligned)

@casperisfine
Copy link
Author

I also noticed

I'd rather not bundle multiple unrelated fixes in the same PR. Makes merging more complicated.

@eregon
Copy link
Member

eregon commented May 9, 2024 •
edited
Loading

Ah sorry, it's @script_safe misaligned, and that's unrelated indeed.

OTOH I think fixing the description of def strict? is very related (but not necessary in this PR, fair enough).

@casperisfine casperisfine force-pushed the fix-strict-pure branch 2 times, most recently from db37392 to 937900c Compare May 9, 2024 13:04
@casperisfine casperisfine requested a review from eregon May 9, 2024 13:05
eregon
eregon approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@byroot byroot merged commit 98ca195 into ruby:master Oct 8, 2024
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strict option is broken for pure-Ruby implementation
3 participants
@casperisfine @eregon @byroot