[out_es] fail on missing index

fail plugin initialization if the index is set to null and the
logstash_format and generate_id options are disabled.

Signed-off-by: Todd Kennedy <[email protected]>

Author: tkennedy1-godaddy

plugins/out_es/es.c

@@ -36,6 +36,7 @@
 #include "es.h"
 #include "es_conf.h"
 #include "es_bulk.h"
+#include "fluent-bit/flb_macros.h"
 #include "murmur3.h"
 
 struct flb_output_plugin out_es_plugin;
@@ -357,9 +358,6 @@ static int elasticsearch_format(struct flb_config *config,
      * this payload.
      */
     if (ctx->logstash_format == FLB_FALSE && ctx->generate_id == FLB_FALSE) {
-        if (ctx->index == NULL) {
-            return -1;
-        }
         flb_time_get(&tms);
         gmtime_r(&tms.tm.tv_sec, &tm);
         strftime(index_formatted, sizeof(index_formatted) - 1,
@@ -630,6 +628,11 @@ static int cb_es_init(struct flb_output_instance *ins,
         return -1;
     }
 
+    if (ctx->index == NULL && ctx->logstash_format == FLB_FALSE && ctx->generate_id == FLB_FALSE) {
+        flb_plg_error(ins, "cannot initialize plugin, index is not set and logstash_format and generate_id are both off");
+        return -1;
+    }
+
     flb_plg_debug(ctx->ins, "host=%s port=%i uri=%s index=%s type=%s",
                   ins->host.name, ins->host.port, ctx->uri,
                   ctx->index, ctx->type);