Skip to content

Commit 79361e6

Browse files
committed
filter_lookup: stability/operational enhancements
- Removed unecessary FLB_FILTER_LOOKUP build flag now LookUp is enabled by default like other filters (without flag). - Fixed critical use-after-free bug in numeric value lookups. - Added processed_records_total, matched_records_total and skipped_records_total metrics to enable operational visibility - Added unit tests to cover handling of different data types, CSV loading/handling and metrics tests. Tested with valgrind - no memory leaks. All unit tests pass. Signed-off-by: Oleg Mukhin <[email protected]>
1 parent fb58a3c commit 79361e6

File tree

6 files changed

+1474
-162
lines changed

6 files changed

+1474
-162
lines changed

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ option(FLB_WASM_STACK_PROTECT "Build with WASM runtime with strong stack protec
196196
option(FLB_ENFORCE_ALIGNMENT "Enable limited platform specific aligned memory access" No)
197197
option(FLB_KAFKA "Enable Kafka support" Yes)
198198
option(FLB_ZIG "Enable zig integration" Yes)
199-
option(FLB_FILTER_LOOKUP "Enable filter lookup support" Yes)
200199

201200
# Native Metrics Support (cmetrics)
202201
option(FLB_METRICS "Enable metrics support" Yes)

cmake/plugins_options.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ DEFINE_OPTION(FLB_FILTER_GEOIP2 "Enable geoip2 filter"
8484
DEFINE_OPTION(FLB_FILTER_GREP "Enable grep filter" ON)
8585
DEFINE_OPTION(FLB_FILTER_KUBERNETES "Enable kubernetes filter" ON)
8686
DEFINE_OPTION(FLB_FILTER_LOG_TO_METRICS "Enable log-derived metrics filter" ON)
87+
DEFINE_OPTION(FLB_FILTER_LOOKUP "Enable lookup filter" ON)
8788
DEFINE_OPTION(FLB_FILTER_LUA "Enable Lua scripting filter" ON)
8889
DEFINE_OPTION(FLB_FILTER_MODIFY "Enable modify filter" ON)
8990
DEFINE_OPTION(FLB_FILTER_MULTILINE "Enable multiline filter" ON)

0 commit comments

Comments
 (0)