Skip to content

Commit 16ac1cf

Browse files
author
Ho
committed
change parameters from memory to calldata in external function
1 parent 4464b42 commit 16ac1cf

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

contracts/FluiDex.sol

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,9 @@ contract FluiDexDemo is AccessControl, IFluiDex, Ownable, ReentrancyGuard {
157157
* @return true if the block was accepted
158158
*/
159159
function verifyBlock(
160-
uint256[] memory _public_inputs,
161-
uint256[] memory _serialized_proof,
162-
bytes memory _public_data
160+
uint256[] calldata _public_inputs,
161+
uint256[] calldata _serialized_proof,
162+
bytes calldata _public_data
163163
) public view returns (bool) {
164164
// _public_inputs[2]/[3] is the low/high 128bit of sha256 hash of _public_data respectively
165165
require(_public_inputs.length >= 4);
@@ -193,9 +193,9 @@ contract FluiDexDemo is AccessControl, IFluiDex, Ownable, ReentrancyGuard {
193193
*/
194194
function submitBlock(
195195
uint256 _block_id,
196-
uint256[] memory _public_inputs,
197-
uint256[] memory _serialized_proof,
198-
bytes memory _public_data
196+
uint256[] calldata _public_inputs,
197+
uint256[] calldata _serialized_proof,
198+
bytes calldata _public_data
199199
) external override returns (bool) {
200200
require(_public_inputs.length >= 2);
201201
if (_block_id == 0) {
@@ -251,8 +251,8 @@ contract FluiDexDemo is AccessControl, IFluiDex, Ownable, ReentrancyGuard {
251251
*/
252252
function submitBlockLegacy(
253253
uint256 _block_id,
254-
uint256[] memory _public_inputs,
255-
uint256[] memory _serialized_proof
254+
uint256[] calldata _public_inputs,
255+
uint256[] calldata _serialized_proof
256256
) external returns (bool) {
257257
// _public_inputs[0] is previous_state_root
258258
// _public_inputs[1] is new_state_root

contracts/FluiDexDelegate.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,9 @@ contract FluiDexDelegate is
103103
*/
104104
function submitBlock(
105105
uint256 _block_id,
106-
uint256[] memory _public_inputs,
107-
uint256[] memory _serialized_proof,
108-
bytes memory _public_data
106+
uint256[] calldata _public_inputs,
107+
uint256[] calldata _serialized_proof,
108+
bytes calldata _public_data
109109
) external override returns (bool) {
110110
return
111111
target.submitBlock(

contracts/IFluiDex.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ interface IFluiDex {
4949
*/
5050
function submitBlock(
5151
uint256 _block_id,
52-
uint256[] memory _public_inputs,
53-
uint256[] memory _serialized_proof,
54-
bytes memory _public_data
52+
uint256[] calldata _public_inputs,
53+
uint256[] calldata _serialized_proof,
54+
bytes calldata _public_data
5555
) external returns (bool);
5656

5757
/**

contracts/IFluiDexDelegate.sol

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ interface IFluiDexDelegate {
3737
*/
3838
function submitBlock(
3939
uint256 _block_id,
40-
uint256[] memory _public_inputs,
41-
uint256[] memory _serialized_proof,
42-
bytes memory _public_data
40+
uint256[] calldata _public_inputs,
41+
uint256[] calldata _serialized_proof,
42+
bytes calldata _public_data
4343
) external returns (bool);
4444
}

0 commit comments

Comments
 (0)