Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad contrast for highlighted search results in tables #9010

Open
DanTup opened this issue Mar 10, 2025 · 3 comments
Open

Bad contrast for highlighted search results in tables #9010

DanTup opened this issue Mar 10, 2025 · 3 comments
Labels
cross-screen Issues that affect multiple DevTools screens, i.e. shared functionality and widgets P2 important to work on, but not at the top of the work list. polish product-quality Issues related to product quality.

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 10, 2025

If I type to search in the CPU profiler, the results are highlighted in a colour that makes it difficult to read the text:

Image
@kenzieschmoll
Copy link
Member

What flutter version are you on? I saw something strange like this recently where the selected search match was pink. There may have been some regression or change with how colors are handled in flutter.

@kenzieschmoll kenzieschmoll added polish P2 important to work on, but not at the top of the work list. cross-screen Issues that affect multiple DevTools screens, i.e. shared functionality and widgets labels Mar 10, 2025
@kenzieschmoll kenzieschmoll changed the title Bad contrast for highlighted search results in CPU Profile Bad contrast for highlighted search results in tables Mar 10, 2025
@kenzieschmoll kenzieschmoll added the product-quality Issues related to product quality. label Mar 10, 2025
@DanTup
Copy link
Contributor Author

DanTup commented Mar 10, 2025

What flutter version are you on?

It was using a Flutter master from this morning (flutter/flutter@0824970), as I was reproducing dart-lang/sdk#60293.

@DanTup
Copy link
Contributor Author

DanTup commented Mar 10, 2025

Oh, I just went to verify this and searched for "dart" and I also got a pink row, but mostly yellow(?).

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cross-screen Issues that affect multiple DevTools screens, i.e. shared functionality and widgets P2 important to work on, but not at the top of the work list. polish product-quality Issues related to product quality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanTup @kenzieschmoll