[CQ][perf] remove unused LOG instances (#8164)

Removes unused `LOG` instances.

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>

Author: pq

flutter-idea/src/io/flutter/FlutterUtils.java

@@ -16,7 +16,6 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.project.ProjectManager;
 import com.intellij.openapi.roots.*;
-import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.openapi.vfs.LocalFileSystem;
 import com.intellij.openapi.vfs.VfsUtil;
 import com.intellij.openapi.vfs.VirtualFile;
@@ -560,7 +559,8 @@ public static EmbeddedBrowser embeddedBrowser(Project project) {
   }
 
   public static boolean embeddedBrowserAvailable(JxBrowserStatus status) {
-    return Objects.equals(status, JxBrowserStatus.INSTALLED) || status.equals(JxBrowserStatus.INSTALLATION_SKIPPED) && FlutterSettings.getInstance()
-      .isEnableJcefBrowser();
+    return Objects.equals(status, JxBrowserStatus.INSTALLED) ||
+           status.equals(JxBrowserStatus.INSTALLATION_SKIPPED) && FlutterSettings.getInstance()
+             .isEnableJcefBrowser();
   }
 }

flutter-idea/src/io/flutter/ProjectOpenActivity.java

@@ -15,7 +15,6 @@
 import com.intellij.openapi.actionSystem.AnAction;
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.extensions.PluginId;
 import com.intellij.openapi.project.DumbAware;
 import com.intellij.openapi.project.Project;
@@ -43,7 +42,6 @@
  */
 public class ProjectOpenActivity implements StartupActivity, DumbAware {
   public static final ProjectType FLUTTER_PROJECT_TYPE = new ProjectType("io.flutter");
-  private static final Logger LOG = Logger.getInstance(ProjectOpenActivity.class);
 
   public ProjectOpenActivity() {
   }
@@ -125,7 +123,7 @@ public PackagesOutOfDateNotification(@NotNull Project project, @NotNull PubRoot
       super("Flutter Packages", "The pubspec.yaml file has been modified since " +
                                 "the last time 'flutter pub get' was run.", NotificationType.INFORMATION);
       setIcon(FlutterIcons.Flutter);
-      
+
       myProject = project;
       myRoot = root;
 

flutter-idea/src/io/flutter/actions/FlutterSdkAction.java

@@ -7,7 +7,6 @@
 
 import com.intellij.openapi.actionSystem.AnActionEvent;
 import com.intellij.openapi.actionSystem.DataContext;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.fileEditor.FileDocumentManager;
 import com.intellij.openapi.project.DumbAwareAction;
 import com.intellij.openapi.project.Project;
@@ -29,8 +28,6 @@
  */
 public abstract class FlutterSdkAction extends DumbAwareAction {
 
-  private static final Logger LOG = Logger.getInstance(FlutterSdkAction.class);
-
   @Override
   public void actionPerformed(@NotNull AnActionEvent event) {
     final Project project = DumbAwareAction.getEventProject(event);

flutter-idea/src/io/flutter/actions/OpenInAndroidStudioAction.java

@@ -12,7 +12,6 @@
 import com.intellij.execution.process.ProcessEvent;
 import com.intellij.openapi.actionSystem.*;
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.editor.CaretModel;
 import com.intellij.openapi.editor.Editor;
 import com.intellij.openapi.fileEditor.FileEditor;
@@ -43,7 +42,6 @@ public class OpenInAndroidStudioAction extends AnAction {
   private static final String DESCR_FILE = FlutterBundle.message("flutter.androidstudio.open.file.description");
   private static final String LABEL_MODULE = FlutterBundle.message("flutter.androidstudio.open.module.text");
   private static final String DESCR_MODULE = FlutterBundle.message("flutter.androidstudio.open.module.description");
-  private static final Logger LOG = Logger.getInstance(OpenInAndroidStudioAction.class);
 
   @Override
   public void update(@NotNull AnActionEvent event) {
@@ -112,7 +110,7 @@ private static Editor getCurrentEditor(@NotNull Project project, @Nullable Virtu
       return null;
     }
     final FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
-    if(fileEditorManager == null) {
+    if (fileEditorManager == null) {
       return null;
     }
     final FileEditor fileEditor = fileEditorManager.getSelectedEditor(file);

flutter-idea/src/io/flutter/android/IntelliJAndroidSdk.java

@@ -6,7 +6,6 @@
 package io.flutter.android;
 
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.projectRoots.ProjectJdkTable;
 import com.intellij.openapi.projectRoots.Sdk;
@@ -26,7 +25,6 @@
  * An Android SDK and its home directory; this references an IntelliJ @{@link Sdk} instance.
  */
 public class IntelliJAndroidSdk {
-  private static final Logger LOG = Logger.getInstance(IntelliJAndroidSdk.class);
 
   @NotNull
   private final Sdk sdk;

flutter-idea/src/io/flutter/bazel/Workspace.java

@@ -9,7 +9,6 @@
 import com.google.common.base.Joiner;
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableSet;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.roots.ProjectRootManager;
@@ -309,7 +308,8 @@ static Workspace loadUncached(@NotNull Project project) {
 
     final String updatedIosRunMessage = config == null ? null : config.getUpdatedIosRunMessage();
 
-    return new Workspace(root, config, daemonScript, devToolsScript, doctorScript, testScript, runScript, syncScript, toolsScript, sdkHome, requiredIJPluginID, requiredIJPluginMessage, configWarningPrefix, updatedIosRunMessage);
+    return new Workspace(root, config, daemonScript, devToolsScript, doctorScript, testScript, runScript, syncScript, toolsScript, sdkHome,
+                         requiredIJPluginID, requiredIJPluginMessage, configWarningPrefix, updatedIosRunMessage);
   }
 
   @VisibleForTesting
@@ -393,7 +393,8 @@ private static VirtualFile findContainingWorkspaceFile(@NotNull VirtualFile dir)
           return child;
         }
         dir = dir.getParent();
-      } catch (InvalidVirtualFileAccessException ex) {
+      }
+      catch (InvalidVirtualFileAccessException ex) {
         // The VFS is out of sync.
         return null;
       }
@@ -403,8 +404,6 @@ private static VirtualFile findContainingWorkspaceFile(@NotNull VirtualFile dir)
     return null;
   }
 
-  private static final Logger LOG = Logger.getInstance(Workspace.class);
-
   public String convertPath(String path) {
     if (path.startsWith(Workspace.BAZEL_URI_SCHEME)) {
       return getRoot().getPath() + path.substring(Workspace.BAZEL_URI_SCHEME.length());

flutter-idea/src/io/flutter/editor/FlutterSaveActionsManager.java

@@ -7,7 +7,6 @@
 
 import com.intellij.application.options.CodeStyle;
 import com.intellij.openapi.command.WriteCommandAction;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.editor.Document;
 import com.intellij.openapi.fileEditor.FileDocumentManager;
 import com.intellij.openapi.fileEditor.FileDocumentManagerListener;
@@ -40,7 +39,6 @@
  * A manager class to run actions on save (formatting, organize imports, ...).
  */
 public class FlutterSaveActionsManager {
-  private static final Logger LOG = Logger.getInstance(FlutterSaveActionsManager.class);
 
   /**
    * Initialize the save actions manager for the given project.

flutter-idea/src/io/flutter/inspections/SdkConfigurationNotificationProvider.java

@@ -5,7 +5,6 @@
  */
 package io.flutter.inspections;
 
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.fileEditor.FileEditor;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.module.ModuleUtilCore;
@@ -15,7 +14,6 @@
 import com.intellij.psi.PsiManager;
 import com.intellij.ui.EditorNotificationPanel;
 import com.intellij.ui.EditorNotificationProvider;
-import com.jetbrains.lang.dart.DartFileType;
 import com.jetbrains.lang.dart.DartLanguage;
 import icons.FlutterIcons;
 import io.flutter.FlutterBundle;
@@ -29,7 +27,6 @@
 import java.util.function.Function;
 
 public class SdkConfigurationNotificationProvider implements EditorNotificationProvider {
-  private static final Logger LOG = Logger.getInstance(SdkConfigurationNotificationProvider.class);
 
   @NotNull
   private final Project project;

flutter-idea/src/io/flutter/project/FlutterProjectOpenProcessor.java

@@ -6,7 +6,6 @@
 package io.flutter.project;
 
 import com.intellij.openapi.application.ApplicationInfo;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.vfs.VirtualFile;
@@ -24,7 +23,6 @@
 import java.util.Objects;
 
 public class FlutterProjectOpenProcessor extends ProjectOpenProcessor {
-  private static final Logger LOG = Logger.getInstance(FlutterProjectOpenProcessor.class);
 
   @Override
   public @NotNull String getName() {

flutter-idea/src/io/flutter/project/FlutterProjectStructureDetector.java

@@ -11,7 +11,6 @@
 import com.intellij.ide.util.projectWizard.importSources.ProjectFromSourcesBuilder;
 import com.intellij.ide.util.projectWizard.importSources.ProjectStructureDetector;
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.DumbService;
 import com.intellij.openapi.project.Project;
@@ -32,7 +31,6 @@
 import java.util.*;
 
 public class FlutterProjectStructureDetector extends ProjectStructureDetector {
-  private static final Logger LOG = Logger.getInstance(ProjectStructureDetector.class);
 
   @NotNull
   @Override

flutter-idea/src/io/flutter/run/MainFile.java

@@ -15,7 +15,6 @@
 import com.intellij.psi.PsiFile;
 import com.intellij.psi.PsiManager;
 import com.intellij.psi.util.PsiTreeUtil;
-import com.jetbrains.lang.dart.DartFileType;
 import com.jetbrains.lang.dart.psi.DartFile;
 import com.jetbrains.lang.dart.psi.DartImportStatement;
 import com.jetbrains.lang.dart.util.DartResolveUtil;
@@ -124,7 +123,7 @@ public static MainFile.Result verify(@Nullable String path, Project project) {
   private static VirtualFile findAppDir(@Nullable VirtualFile file, @NotNull Project project) {
     if (WorkspaceCache.getInstance(project).isBazel()) {
       final Workspace workspace = WorkspaceCache.getInstance(project).get();
-      assert(workspace != null);
+      assert (workspace != null);
       return workspace.getRoot();
     }
 
@@ -135,7 +134,7 @@ private static VirtualFile findAppDir(@Nullable VirtualFile file, @NotNull Proje
   }
 
   private static boolean isAppDir(@NotNull VirtualFile dir, @NotNull Project project) {
-    assert(!WorkspaceCache.getInstance(project).isBazel());
+    assert (!WorkspaceCache.getInstance(project).isBazel());
     return dir.isDirectory() && (
       dir.findChild(PubRoot.PUBSPEC_YAML) != null ||
       dir.findChild(PubRoot.DOT_DART_TOOL) != null ||

flutter-idea/src/io/flutter/run/coverage/LcovInfo.java

@@ -5,7 +5,6 @@
  */
 package io.flutter.run.coverage;
 
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.SystemInfo;
 import com.intellij.rt.coverage.data.ClassData;
 import com.intellij.rt.coverage.data.LineData;
@@ -25,7 +24,6 @@
 import java.util.stream.Stream;
 
 public class LcovInfo {
-  private static final Logger LOG = Logger.getInstance(LcovInfo.class.getName());
 
   private static final String FILE_LABEL = "SF:";
   private static final String DATA_LABEL = "DA:";

flutter-idea/src/io/flutter/sdk/FlutterSdkUtil.java

@@ -14,7 +14,6 @@
 import com.intellij.ide.util.PropertiesComponent;
 import com.intellij.openapi.application.ApplicationManager;
 import com.intellij.openapi.application.ApplicationNamesInfo;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.module.Module;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.project.ProjectManager;
@@ -51,7 +50,6 @@ public class FlutterSdkUtil {
   public static final String FLUTTER_HOST_ENV = "FLUTTER_HOST";
 
   private static final String FLUTTER_SDK_KNOWN_PATHS = "FLUTTER_SDK_KNOWN_PATHS";
-  private static final Logger LOG = Logger.getInstance(FlutterSdkUtil.class);
   private static final String FLUTTER_SNAP_SDK_PATH = "/snap/flutter/common/flutter";
 
   public FlutterSdkUtil() {

flutter-idea/src/io/flutter/survey/FlutterSurveyNotifications.java

@@ -17,7 +17,6 @@
 import com.intellij.openapi.fileEditor.FileEditorManagerListener;
 import com.intellij.openapi.project.Project;
 import com.intellij.openapi.vfs.VirtualFile;
-import com.jetbrains.lang.dart.DartFileType;
 import icons.FlutterIcons;
 import io.flutter.FlutterMessages;
 import io.flutter.FlutterUtils;

flutter-idea/src/io/flutter/survey/FlutterSurveyService.java

@@ -9,7 +9,6 @@
 import com.google.gson.JsonSyntaxException;
 import com.intellij.ide.util.PropertiesComponent;
 import com.intellij.openapi.application.ApplicationManager;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.util.io.HttpRequests;
 import io.flutter.utils.JsonUtils;
 import org.jetbrains.annotations.Nullable;
@@ -21,7 +20,6 @@ public class FlutterSurveyService {
   private static final String FLUTTER_LAST_SURVEY_CONTENT_CHECK_KEY = "FLUTTER_LAST_SURVEY_CONTENT_CHECK_KEY";
   private static final long CHECK_INTERVAL_IN_MS = TimeUnit.HOURS.toMillis(40);
   private static final String CONTENT_URL = "https://storage.googleapis.com/flutter-uxr/surveys/flutter-survey-metadata.json";
-  private static final Logger LOG = Logger.getInstance(FlutterSurveyService.class);
   private static @Nullable FlutterSurvey cachedSurvey;
 
   private static boolean timeToUpdateCachedContent() {

flutter-idea/src/io/flutter/utils/FlutterModuleUtils.java

@@ -23,7 +23,6 @@
 import com.intellij.psi.PsiElement;
 import com.intellij.serviceContainer.AlreadyDisposedException;
 import com.intellij.ui.EditorNotifications;
-import com.jetbrains.lang.dart.DartFileType;
 import com.jetbrains.lang.dart.sdk.DartSdk;
 import com.jetbrains.lang.dart.util.PubspecYamlUtil;
 import io.flutter.FlutterUtils;

flutter-idea/src/io/flutter/vmService/HeapMonitor.java

@@ -5,7 +5,6 @@
  */
 package io.flutter.vmService;
 
-import com.intellij.openapi.diagnostic.Logger;
 import org.dartlang.vm.service.consumer.GetMemoryUsageConsumer;
 import org.dartlang.vm.service.element.IsolateRef;
 import org.dartlang.vm.service.element.MemoryUsage;
@@ -18,7 +17,6 @@
 import java.util.concurrent.*;
 
 public class HeapMonitor {
-  private static final Logger LOG = Logger.getInstance(HeapMonitor.class);
 
   private static final ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
 

flutter-idea/src/io/flutter/vmService/VMServiceManager.java

@@ -9,7 +9,6 @@
 import com.google.gson.JsonElement;
 import com.google.gson.JsonObject;
 import com.intellij.openapi.Disposable;
-import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.util.Disposer;
 import com.intellij.openapi.util.text.StringUtil;
 import io.flutter.run.daemon.FlutterApp;
@@ -33,7 +32,6 @@
 import static io.flutter.vmService.ServiceExtensions.enableOnDeviceInspector;
 
 public class VMServiceManager implements FlutterApp.FlutterAppListener, Disposable {
-  private static final Logger LOG = Logger.getInstance(VMServiceManager.class);
 
   @NotNull private final FlutterApp app;
   @NotNull private final HeapMonitor heapMonitor;