[various] Scrubs pre-SDK-21 Android code (#9112)

- Removes any annotations or runtime checks related to Android API 20 or 21, as 21 is the minimum API version supported by the versions of Flutter these plugins support.
- Removes comment/README references to limitations for <21.
- Updates READMEs for app-facing packages to reflect the current support levels.

Fixes flutter/flutter#157106

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Author: stuartmorgan-g

packages/camera/camera_android/android/src/test/java/io/flutter/plugins/camera/CameraTest.java

@@ -663,7 +663,7 @@ public void setDescriptionWhileRecording_errorsWhenUnsupported() {
     camera.mediaRecorder = mockMediaRecorder;
     camera.recordingVideo = true;
     camera.videoRenderer = mockVideoRenderer;
-    SdkCapabilityChecker.SDK_VERSION = Build.VERSION_CODES.LOLLIPOP;
+    SdkCapabilityChecker.SDK_VERSION = Build.VERSION_CODES.N;
 
     final CameraProperties newCameraProperties = mock(CameraProperties.class);
     assertThrows(

packages/camera/camera_android/example/android/build.gradle

@@ -30,7 +30,8 @@ tasks.register("clean", Delete) {
 gradle.projectsEvaluated {
     project(":camera_android") {
         tasks.withType(JavaCompile) {
-            options.compilerArgs << "-Xlint:all" << "-Werror"
+            // Ignore classfile due to https://issuetracker.google.com/issues/342067844
+            options.compilerArgs << "-Xlint:all" << "-Werror" << "-Xlint:-classfile"
         }
     }
 }

packages/espresso/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0+7
+
+* Removes obsolete code related to supporting SDK <21.
+
 ## 0.4.0+6
 
 * Updates compileSdk 34 to flutter.compileSdkVersion.

packages/espresso/README.md

@@ -4,7 +4,7 @@ Provides bindings for Espresso tests of Flutter Android apps.
 
 |             | Android |
 |-------------|---------|
-| **Support** | SDK 16+ |
+| **Support** | SDK 21+ |
 
 ## Installation
 

packages/espresso/android/build.gradle

@@ -26,7 +26,7 @@ android {
     compileSdk = flutter.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion 19
+        minSdkVersion 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 

packages/espresso/pubspec.yaml

@@ -3,7 +3,7 @@ description: Java classes for testing Flutter apps using Espresso.
   Allows driving Flutter widgets from a native Espresso test.
 repository: https://github.com/flutter/packages/tree/main/packages/espresso
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22
-version: 0.4.0+6
+version: 0.4.0+7
 
 environment:
   sdk: ^3.6.0

packages/file_selector/file_selector/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## NEXT
 
+* Updates README to indicate that Andoid SDK <21 is no longer supported.
 * Updates minimum supported SDK version to Flutter 3.22/Dart 3.4.
 
 ## 1.0.3

packages/file_selector/file_selector/README.md

@@ -8,7 +8,7 @@ A Flutter plugin that manages files and interactions with file dialogs.
 
 |             | Android | iOS     | Linux | macOS  | Web | Windows     |
 |-------------|---------|---------|-------|--------|-----|-------------|
-| **Support** | SDK 19+ | iOS 12+ | Any   | 10.14+ | Any | Windows 10+ |
+| **Support** | SDK 21+ | iOS 12+ | Any   | 10.14+ | Any | Windows 10+ |
 
 ## Setup
 
@@ -114,9 +114,7 @@ pass different `XTypeGroup`s based on `Platform`.
 | Choose a single file   | Pick a file/image                  | ✔️       | ✔️       | ✔️        | ✔️       | ✔️          | ✔️          |
 | Choose multiple files  | Pick multiple files/images         | ✔️       | ✔️       | ✔️        | ✔️       | ✔️          | ✔️          |
 | Choose a save location | Pick a directory to save a file in | ❌       | ❌       | ✔️        | ✔️       | ✔️          | ❌          |
-| Choose a directory     | Pick a directory and get its path  | ✔️†       | ❌       | ✔️        | ✔️       | ✔️          | ❌          |
-
-† Choosing a directory is no supported on versions of Android before SDK 21 (Lollipop).
+| Choose a directory     | Pick a directory and get its path  | ✔️       | ❌       | ✔️        | ✔️       | ✔️          | ❌          |
 
 [example]:./example
 [entitlement]: https://docs.flutter.dev/desktop#entitlements-and-the-app-sandbox

packages/file_selector/file_selector_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.1+14
+
+* Removes obsolete code related to supporting SDK <21.
+
 ## 0.5.1+13
 
 * Updates compileSdk 34 to flutter.compileSdkVersion.

packages/file_selector/file_selector_android/android/build.gradle

@@ -31,7 +31,7 @@ android {
     }
 
     defaultConfig {
-        minSdkVersion 19
+        minSdkVersion 21
     }
 
     dependencies {

packages/file_selector/file_selector_android/android/src/main/java/dev/flutter/packages/file_selector_android/FileSelectorApiImpl.java

@@ -6,7 +6,6 @@
 
 import static dev.flutter.packages.file_selector_android.FileUtils.FILE_SELECTOR_EXCEPTION_PLACEHOLDER_PATH;
 
-import android.annotation.TargetApi;
 import android.app.Activity;
 import android.content.ClipData;
 import android.content.ContentResolver;
@@ -193,17 +192,9 @@ public void onResult(int resultCode, @Nullable Intent data) {
   }
 
   @Override
-  @TargetApi(21)
   public void getDirectoryPath(
       @Nullable String initialDirectory,
       @NonNull GeneratedFileSelectorApi.NullableResult<String> result) {
-    if (!sdkChecker.sdkIsAtLeast(android.os.Build.VERSION_CODES.LOLLIPOP)) {
-      result.error(
-          new UnsupportedOperationException(
-              "Selecting a directory is only supported on versions >= 21"));
-      return;
-    }
-
     final Intent intent = objectFactory.newIntent(Intent.ACTION_OPEN_DOCUMENT_TREE);
     trySetInitialDirectory(intent, initialDirectory);
 

packages/file_selector/file_selector_android/android/src/test/java/dev/flutter/packages/file_selector_android/FileSelectorAndroidPluginTest.java

@@ -443,7 +443,7 @@ public void getDirectoryPathReturnsSuccessfully() {
             new FileSelectorApiImpl(
                 mockActivityBinding,
                 mockObjectFactory,
-                (version) -> Build.VERSION_CODES.LOLLIPOP >= version);
+                (version) -> Build.VERSION.SDK_INT >= version);
 
         final GeneratedFileSelectorApi.NullableResult mockResult =
             mock(GeneratedFileSelectorApi.NullableResult.class);
@@ -465,20 +465,4 @@ public void getDirectoryPathReturnsSuccessfully() {
       }
     }
   }
-
-  @Test
-  public void getDirectoryPath_errorsForUnsupportedVersion() {
-    final FileSelectorApiImpl fileSelectorApi =
-        new FileSelectorApiImpl(
-            mockActivityBinding,
-            mockObjectFactory,
-            (version) -> Build.VERSION_CODES.KITKAT >= version);
-
-    @SuppressWarnings("unchecked")
-    final GeneratedFileSelectorApi.NullableResult<String> mockResult =
-        mock(GeneratedFileSelectorApi.NullableResult.class);
-    fileSelectorApi.getDirectoryPath(null, mockResult);
-
-    verify(mockResult).error(any());
-  }
 }

packages/file_selector/file_selector_android/example/android/build.gradle

@@ -30,7 +30,8 @@ tasks.register("clean", Delete) {
 gradle.projectsEvaluated {
     project(":file_selector_android") {
         tasks.withType(JavaCompile) {
-            options.compilerArgs << "-Xlint:all" << "-Werror"
+            // Ignore classfile due to https://issuetracker.google.com/issues/342067844
+            options.compilerArgs << "-Xlint:all" << "-Werror" << "-Xlint:-classfile"
         }
     }
 }

packages/file_selector/file_selector_android/pubspec.yaml

@@ -2,7 +2,7 @@ name: file_selector_android
 description: Android implementation of the file_selector package.
 repository: https://github.com/flutter/packages/tree/main/packages/file_selector/file_selector_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.5.1+13
+version: 0.5.1+14
 
 environment:
   sdk: ^3.6.0

packages/flutter_plugin_android_lifecycle/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.0.28
+
+* Removes obsolete code related to supporting SDK <21.
+
 ## 2.0.27
 
 * Bumps flutter supported version to 3.27 and use flutter.compileSdkVersion.

packages/flutter_plugin_android_lifecycle/README.md

@@ -11,7 +11,7 @@ major version of the Android `Lifecycle` API they expect.
 
 |             | Android |
 |-------------|---------|
-| **Support** | SDK 16+ |
+| **Support** | SDK 21+ |
 
 ## Example
 

packages/flutter_plugin_android_lifecycle/android/build.gradle

@@ -26,7 +26,7 @@ android {
     compileSdk = flutter.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion 19
+        minSdkVersion 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         consumerProguardFiles 'proguard.txt'
     }

packages/flutter_plugin_android_lifecycle/pubspec.yaml

@@ -2,7 +2,7 @@ name: flutter_plugin_android_lifecycle
 description: Flutter plugin for accessing an Android Lifecycle within other plugins.
 repository: https://github.com/flutter/packages/tree/main/packages/flutter_plugin_android_lifecycle
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+flutter_plugin_android_lifecycle%22
-version: 2.0.27
+version: 2.0.28
 
 environment:
   sdk: ^3.6.0

packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md

@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates README to indicate that Andoid SDK <21 is no longer supported.
+
 ## 2.12.1
 
 * Fixes typo in README.

packages/google_maps_flutter/google_maps_flutter/README.md

@@ -8,7 +8,7 @@ A Flutter plugin that provides a [Google Maps](https://developers.google.com/map
 
 |             | Android | iOS     | Web                              |
 |-------------|---------|---------|----------------------------------|
-| **Support** | SDK 20+ | iOS 14+ | Same as [Flutter's][web-support] |
+| **Support** | SDK 21+ | iOS 14+ | Same as [Flutter's][web-support] |
 
 [web-support]: https://docs.flutter.dev/reference/supported-platforms
 

packages/google_maps_flutter/google_maps_flutter_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.16.1
+
+* Removes obsolete code related to supporting SDK <21.
+
 ## 2.16.0
 
 * Adds support for animating the camera with a duration.

packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle

@@ -26,7 +26,7 @@ android {
     compileSdk = flutter.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion 20
+        minSdkVersion 21
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/ClusterManagersControllerTest.java

@@ -16,7 +16,6 @@
 import android.content.Context;
 import android.content.res.AssetManager;
 import android.graphics.Bitmap;
-import android.os.Build;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.android.gms.maps.GoogleMap;
 import com.google.android.gms.maps.model.CameraPosition;
@@ -41,10 +40,8 @@
 import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class ClusterManagersControllerTest {
   private Context context;
   private MapsCallbackApi flutterApi;

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/ConvertTest.java

@@ -24,7 +24,6 @@
 import static org.mockito.Mockito.when;
 
 import android.content.res.AssetManager;
-import android.os.Build;
 import android.util.Base64;
 import androidx.annotation.NonNull;
 import com.google.android.gms.maps.model.BitmapDescriptor;
@@ -49,10 +48,8 @@
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class ConvertTest {
   @Mock private AssetManager assetManager;
 

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/GoogleMapControllerTest.java

@@ -18,7 +18,6 @@
 import static org.mockito.Mockito.when;
 
 import android.content.Context;
-import android.os.Build;
 import androidx.activity.ComponentActivity;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.android.gms.maps.CameraUpdate;
@@ -41,10 +40,8 @@
 import org.mockito.MockitoAnnotations;
 import org.robolectric.Robolectric;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class GoogleMapControllerTest {
 
   private Context context;

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/GoogleMapInitializerTest.java

@@ -13,7 +13,6 @@
 import static org.mockito.Mockito.verify;
 
 import android.content.Context;
-import android.os.Build;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.android.gms.maps.MapsInitializer.Renderer;
 import io.flutter.plugin.common.BinaryMessenger;
@@ -23,10 +22,8 @@
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class GoogleMapInitializerTest {
   private GoogleMapInitializer googleMapInitializer;
 

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/GroundOverlaysControllerTest.java

@@ -12,7 +12,6 @@
 
 import android.content.Context;
 import android.content.res.AssetManager;
-import android.os.Build;
 import android.util.Base64;
 import androidx.annotation.NonNull;
 import androidx.test.core.app.ApplicationProvider;
@@ -31,10 +30,8 @@
 import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class GroundOverlaysControllerTest {
   @Mock private BitmapDescriptorFactoryWrapper bitmapDescriptorFactoryWrapper;
   @Mock private BitmapDescriptor mockBitmapDescriptor;

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/HeatmapsControllerTest.java

@@ -15,7 +15,6 @@
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.when;
 
-import android.os.Build;
 import com.google.android.gms.maps.GoogleMap;
 import com.google.android.gms.maps.model.TileOverlay;
 import com.google.android.gms.maps.model.TileOverlayOptions;
@@ -30,10 +29,8 @@
 import org.junit.runner.RunWith;
 import org.mockito.Mockito;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class HeatmapsControllerTest {
   private HeatmapsController controller;
   private GoogleMap googleMap;

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/MarkersControllerTest.java

@@ -15,7 +15,6 @@
 import android.content.Context;
 import android.content.res.AssetManager;
 import android.graphics.Bitmap;
-import android.os.Build;
 import androidx.test.core.app.ApplicationProvider;
 import com.google.android.gms.maps.GoogleMap;
 import com.google.android.gms.maps.model.LatLng;
@@ -36,10 +35,8 @@
 import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.annotation.Config;
 
 @RunWith(RobolectricTestRunner.class)
-@Config(minSdk = Build.VERSION_CODES.LOLLIPOP)
 public class MarkersControllerTest {
   private Context context;
   private MapsCallbackApi flutterApi;

packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml

@@ -2,7 +2,7 @@ name: google_maps_flutter_android
 description: Android implementation of the google_maps_flutter plugin.
 repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
-version: 2.16.0
+version: 2.16.1
 
 environment:
   sdk: ^3.6.0

packages/google_sign_in/google_sign_in/CHANGELOG.md

@@ -1,3 +1,7 @@
+## NEXT
+
+* Updates README to indicate that Andoid SDK <21 is no longer supported.
+
 ## 6.3.0
 
 * Adds a sign-in field to allow Android clients to explicitly specify an account name. This