Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Deprecates dartHostTestHandler, in preparation for removing sometime in 2026 if no significant new information comes to light.

Part of flutter/flutter#178322

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Deprecates `dartHostTestHandler`, in preparation for removing sometime
in 2026 if no significant new information comes to light.

Part of flutter/flutter#178322
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Collaborator Author

test-exempt: deprecating existing code

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively deprecates dartHostTestHandler and its associated option dartTestOut. The changes are consistent across the codebase, including updates to the API, options, version, and changelog.

To make the deprecation more complete, you might also consider deprecating the dart_test_out command-line option in _argParser (in packages/pigeon/lib/src/pigeon_lib.dart) by marking it as hidden (hide: true) and updating its help text. This would make the command-line interface consistent with the API deprecation.

I have one minor suggestion to make the changelog entry more explicit.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2025
@auto-submit auto-submit bot merged commit d07dabc into flutter:main Nov 12, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants