Enforce use_key_in_widget_constructors and file_names lints (#913)

* Start enforcing use_key_in_widget_constructors and file_names lints

* dart format

* analysis fixes

* analysis fixes, pt2

* analysis fixes, part 3

* Revert platform_design (test failure)

* More reverts

* Notate why we aren't enforcing a lint

Author: domesticmouse

add_to_app/android_view/flutter_module_using_plugin/test/widget_test.dart

@@ -6,9 +6,8 @@
 // tree, read text, and verify that the values of widget properties are correct.
 
 import 'package:flutter/material.dart';
-import 'package:flutter_test/flutter_test.dart';
-
 import 'package:flutter_module_using_plugin/main.dart';
+import 'package:flutter_test/flutter_test.dart';
 import 'package:provider/provider.dart';
 
 class MockCounterModel extends ChangeNotifier implements CounterModel {

add_to_app/books/flutter_module_books/lib/api.dart

@@ -94,6 +94,7 @@ abstract class FlutterBookApi {
       if (api == null) {
         channel.setMessageHandler(null);
       } else {
+        // ignore: avoid_types_on_closure_parameters
         channel.setMessageHandler((Object? message) async {
           assert(message != null,
               'Argument for dev.flutter.pigeon.FlutterBookApi.displayBookDetails was null.');

experimental/federated_plugin/federated_plugin_platform_interface/pubspec.yaml

@@ -1,7 +1,6 @@
 name: federated_plugin_platform_interface
 description: A platform interface for federated_plugin.
 version: 0.0.1
-author:
 homepage:
 publish_to: none
 

experimental/federated_plugin/federated_plugin_windows/pubspec.yaml

@@ -1,7 +1,6 @@
 name: federated_plugin_windows
 description: Windows implementation of federated_plugin to retrieve current battery level.
 version: 0.0.1
-author:
 homepage:
 publish_to: none
 

experimental/linting_tool/analysis_options.yaml

@@ -15,10 +15,8 @@ linter:
     cancel_subscriptions: true
     close_sinks: true
     directives_ordering: true
-    file_names: false
     package_api_docs: true
     package_prefixed_library_names: true
     test_types_in_equals: true
     throw_in_finally: true
     unnecessary_statements: true
-    use_key_in_widget_constructors: false

experimental/web_dashboard/analysis_options.yaml

@@ -17,4 +17,3 @@ linter:
     test_types_in_equals: true
     throw_in_finally: true
     unnecessary_statements: true
-    use_key_in_widget_constructors: false

experimental/web_dashboard/lib/src/app.dart

@@ -39,14 +39,16 @@ class DashboardApp extends StatefulWidget {
   final ApiBuilder apiBuilder;
 
   /// Runs the app using Firebase
-  DashboardApp.firebase()
+  DashboardApp.firebase({Key key})
       : auth = FirebaseAuthService(),
-        apiBuilder = _apiBuilder;
+        apiBuilder = _apiBuilder,
+        super(key: key);
 
   /// Runs the app using mock data
-  DashboardApp.mock()
+  DashboardApp.mock({Key key})
       : auth = MockAuthService(),
-        apiBuilder = _mockApiBuilder;
+        apiBuilder = _mockApiBuilder,
+        super(key: key);
 
   @override
   _DashboardAppState createState() => _DashboardAppState();
@@ -84,7 +86,8 @@ class SignInSwitcher extends StatefulWidget {
   const SignInSwitcher({
     this.appState,
     this.apiBuilder,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _SignInSwitcherState createState() => _SignInSwitcherState();

experimental/web_dashboard/lib/src/pages/dashboard.dart

@@ -10,6 +10,8 @@ import '../app.dart';
 import '../widgets/category_chart.dart';
 
 class DashboardPage extends StatelessWidget {
+  const DashboardPage({Key key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     var appState = Provider.of<AppState>(context);
@@ -41,7 +43,7 @@ class DashboardPage extends StatelessWidget {
 class Dashboard extends StatelessWidget {
   final List<Category> categories;
 
-  const Dashboard(this.categories);
+  const Dashboard(this.categories, {Key key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

experimental/web_dashboard/lib/src/pages/entries.dart

@@ -12,6 +12,8 @@ import '../widgets/categories_dropdown.dart';
 import '../widgets/dialogs.dart';
 
 class EntriesPage extends StatefulWidget {
+  const EntriesPage({Key key}) : super(key: key);
+
   @override
   _EntriesPageState createState() => _EntriesPageState();
 }
@@ -100,7 +102,8 @@ class EntryTile extends StatelessWidget {
   const EntryTile({
     this.category,
     this.entry,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

experimental/web_dashboard/lib/src/pages/home.dart

@@ -14,7 +14,8 @@ class HomePage extends StatefulWidget {
 
   const HomePage({
     @required this.onSignOut,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _HomePageState createState() => _HomePageState();
@@ -70,15 +71,15 @@ class _HomePageState extends State<HomePage> {
     if (_pageIndex == 0) {
       showDialog<NewCategoryDialog>(
         context: context,
-        builder: (context) => NewCategoryDialog(),
+        builder: (context) => const NewCategoryDialog(),
       );
       return;
     }
 
     if (_pageIndex == 1) {
       showDialog<NewEntryDialog>(
         context: context,
-        builder: (context) => NewEntryDialog(),
+        builder: (context) => const NewEntryDialog(),
       );
       return;
     }
@@ -115,11 +116,11 @@ class _HomePageState extends State<HomePage> {
 
   static Widget _pageAtIndex(int index) {
     if (index == 0) {
-      return DashboardPage();
+      return const DashboardPage();
     }
 
     if (index == 1) {
-      return EntriesPage();
+      return const EntriesPage();
     }
 
     return const Center(child: Text('Settings page'));

experimental/web_dashboard/lib/src/pages/sign_in.dart

@@ -13,7 +13,8 @@ class SignInPage extends StatelessWidget {
   const SignInPage({
     @required this.auth,
     @required this.onSuccess,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
@@ -32,7 +33,8 @@ class SignInButton extends StatefulWidget {
   const SignInButton({
     @required this.auth,
     @required this.onSuccess,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _SignInButtonState createState() => _SignInButtonState();

experimental/web_dashboard/lib/src/widgets/categories_dropdown.dart

@@ -16,7 +16,8 @@ class CategoryDropdown extends StatefulWidget {
   const CategoryDropdown({
     @required this.api,
     @required this.onSelected,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _CategoryDropdownState createState() => _CategoryDropdownState();

experimental/web_dashboard/lib/src/widgets/category_chart.dart

@@ -20,7 +20,8 @@ class CategoryChart extends StatelessWidget {
   const CategoryChart({
     @required this.category,
     @required this.api,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

experimental/web_dashboard/lib/src/widgets/category_forms.dart

@@ -8,6 +8,8 @@ import 'package:web_dashboard/src/api/api.dart';
 import 'package:web_dashboard/src/app.dart';
 
 class NewCategoryForm extends StatefulWidget {
+  const NewCategoryForm({Key key}) : super(key: key);
+
   @override
   _NewCategoryFormState createState() => _NewCategoryFormState();
 }
@@ -37,7 +39,8 @@ class EditCategoryForm extends StatefulWidget {
   const EditCategoryForm({
     @required this.category,
     @required this.onDone,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _EditCategoryFormState createState() => _EditCategoryFormState();

experimental/web_dashboard/lib/src/widgets/dialogs.dart

@@ -11,10 +11,12 @@ import '../app.dart';
 import 'edit_entry.dart';
 
 class NewCategoryDialog extends StatelessWidget {
+  const NewCategoryDialog({Key key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
-    return SimpleDialog(
-      title: const Text('New Category'),
+    return const SimpleDialog(
+      title: Text('New Category'),
       children: <Widget>[
         NewCategoryForm(),
       ],
@@ -27,7 +29,8 @@ class EditCategoryDialog extends StatelessWidget {
 
   const EditCategoryDialog({
     @required this.category,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
@@ -51,15 +54,17 @@ class EditCategoryDialog extends StatelessWidget {
 }
 
 class NewEntryDialog extends StatefulWidget {
+  const NewEntryDialog({Key key}) : super(key: key);
+
   @override
   _NewEntryDialogState createState() => _NewEntryDialogState();
 }
 
 class _NewEntryDialogState extends State<NewEntryDialog> {
   @override
   Widget build(BuildContext context) {
-    return SimpleDialog(
-      title: const Text('New Entry'),
+    return const SimpleDialog(
+      title: Text('New Entry'),
       children: [
         NewEntryForm(),
       ],
@@ -74,7 +79,8 @@ class EditEntryDialog extends StatelessWidget {
   const EditEntryDialog({
     this.category,
     this.entry,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

experimental/web_dashboard/lib/src/widgets/edit_entry.dart

@@ -11,6 +11,8 @@ import '../app.dart';
 import 'categories_dropdown.dart';
 
 class NewEntryForm extends StatefulWidget {
+  const NewEntryForm({Key key}) : super(key: key);
+
   @override
   _NewEntryFormState createState() => _NewEntryFormState();
 }
@@ -58,7 +60,8 @@ class EditEntryForm extends StatefulWidget {
   const EditEntryForm({
     @required this.entry,
     @required this.onDone,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _EditEntryFormState createState() => _EditEntryFormState();

experimental/web_dashboard/lib/src/widgets/third_party/adaptive_scaffold.dart

@@ -43,7 +43,8 @@ class AdaptiveScaffold extends StatefulWidget {
     @required this.destinations,
     this.onNavigationIndexChange,
     this.floatingActionButton,
-  });
+    Key key,
+  }) : super(key: key);
 
   @override
   _AdaptiveScaffoldState createState() => _AdaptiveScaffoldState();

platform_channels/analysis_options.yaml

@@ -12,10 +12,8 @@ linter:
     cancel_subscriptions: true
     close_sinks: true
     directives_ordering: true
-    file_names: false
     package_api_docs: true
     package_prefixed_library_names: true
     test_types_in_equals: true
     throw_in_finally: true
     unnecessary_statements: true
-    use_key_in_widget_constructors: false

platform_channels/lib/main.dart

@@ -10,27 +10,29 @@ import 'package:platform_channels/src/pet_list_screen.dart';
 import 'package:platform_channels/src/platform_image_demo.dart';
 
 void main() {
-  runApp(PlatformChannelSample());
+  runApp(const PlatformChannelSample());
 }
 
 class PlatformChannelSample extends StatelessWidget {
+  const PlatformChannelSample({Key? key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
       routes: {
-        '/methodChannelDemo': (context) => MethodChannelDemo(),
-        '/eventChannelDemo': (context) => EventChannelDemo(),
-        '/platformImageDemo': (context) => PlatformImageDemo(),
-        '/petListScreen': (context) => PetListScreen(),
-        '/addPetDetails': (context) => AddPetDetails(),
+        '/methodChannelDemo': (context) => const MethodChannelDemo(),
+        '/eventChannelDemo': (context) => const EventChannelDemo(),
+        '/platformImageDemo': (context) => const PlatformImageDemo(),
+        '/petListScreen': (context) => const PetListScreen(),
+        '/addPetDetails': (context) => const AddPetDetails(),
       },
       title: 'Platform Channel Sample',
       theme: ThemeData(
         snackBarTheme: SnackBarThemeData(
           backgroundColor: Colors.blue[500],
         ),
       ),
-      home: HomePage(),
+      home: const HomePage(),
     );
   }
 }
@@ -62,6 +64,8 @@ List<DemoInfo> demoList = [
 ];
 
 class HomePage extends StatelessWidget {
+  const HomePage({Key? key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return Scaffold(
@@ -79,7 +83,7 @@ class HomePage extends StatelessWidget {
 class DemoTile extends StatelessWidget {
   final DemoInfo demoInfo;
 
-  const DemoTile(this.demoInfo);
+  const DemoTile(this.demoInfo, {Key? key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {

platform_channels/lib/src/add_pet_details.dart

@@ -10,6 +10,8 @@ import 'package:platform_channels/src/pet_list_message_channel.dart';
 /// The widget uses [TextField] and [RadioListTile] to take the [PetDetails.breed] and
 /// [PetDetails.petType] from the user respectively.
 class AddPetDetails extends StatefulWidget {
+  const AddPetDetails({Key? key}) : super(key: key);
+
   @override
   _AddPetDetailsState createState() => _AddPetDetailsState();
 }

platform_channels/lib/src/event_channel_demo.dart

@@ -14,6 +14,8 @@ import 'package:platform_channels/src/accelerometer_event_channel.dart';
 /// [Text] widgets to display the value of [AccelerometerReadings.x],
 /// [AccelerometerReadings.y], and [AccelerometerReadings.z] respectively.
 class EventChannelDemo extends StatelessWidget {
+  const EventChannelDemo({Key? key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     final textStyle = Theme.of(context).textTheme.headline5;

platform_channels/lib/src/method_channel_demo.dart

@@ -10,6 +10,8 @@ import 'package:platform_channels/src/counter_method_channel.dart';
 /// It has two [ElevatedButton]s to increment and decrement the value of
 /// [count], and a [Text] widget to display its value.
 class MethodChannelDemo extends StatefulWidget {
+  const MethodChannelDemo({Key? key}) : super(key: key);
+
   @override
   _MethodChannelDemoState createState() => _MethodChannelDemoState();
 }