Property supportMultipleWindows of Android WebView needs to have onCreateWindow implemented

[kaciula]

Issue occurs on: Android
Plugin version: 0.3.8
Flutter doctor output:

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G87, locale en-RO)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.38.1)
[✓] Connected device (2 available)

• No issues found!

I am trying to implement login with Facebook. During the process, Facebook needs to open a new window and then to do the redirect. On Android native you would set supportMultipleWindows to true on the WebView and you would catch the onCreateWindow() callback and open the url in a new WebView.

I tried setting supportMultipleWindows: true on the WebViewScaffold but then pressing the Login Facebook button does not do anything.

The documentation on Android WebView says that if you set supportMultipleWindows: true you NEED to override onCreateWindow(). Is this possible with your plugin? Am I missing something obvious? Why would you have the supportMultipleWindows property on the WebViewScaffold but not support for the corresponding onCreateWindow()?

Any help is greatly appreciated because I am stuck.

[charafau]

hi, it might not be possible to do that, but investigation is needed.

I use this plugin for oauth2 and it works normally but if you need to do facebook login, try facebook plugin for flutter https://pub.dev/packages/flutter_facebook_login

[kaciula]

@charafau My specific issue is that first I load the WebView with a page that lists several ways to authenticate. When clicking the button for Facebook oauth, the page tries to open a new window. This is how Facebook oauth works. It opens a new window where it does its thing and then closes its window.

I've looked into the implementation of this plugin and it does not offer support for this kind of behavior. The property supportMultipleWindows is useless without overriding the onCreateWindow() callback and there is no way to do this with this plugin.

I've ended up using my own native Android WebView. Thanks for replying.

[cyrilccs]

@kaciula same issue, did you find a solution ?

[kaciula]

@cyrilccs I've mentioned in my last post that I've used my own Android WebView activity. I stopped using this plugin and went the native way.

1. Create an Android Activity that hosts a WebView, set supportMultipleWindows to true and override onCreateWindow(). You can find the exact details on stackoverflow.

2. From flutter, start the WebActivity using the method channel present in the MainActivity. Use startActivityForResult() from MainActivity to get back the data you need and then send it back to flutter using the same method channel.

[whiteLT]

Any news on fixing this?

[sam-parks]

I'm having this same issue on iOS with Google Auth.

I think this plugin would really benefit from supporting the creation of new windows.

[sam-parks]

Here is my use case where I cannot navigate from the completed OAuth URL because I do not have multiple windows:

[augustorsouza]

Hello guys, any news on this?

For now I am thinking on going with workaround of injecting a JS that override window.open method to avoid _blank argument. But, I don´t think this solution is good enough:

var orgOpen = window.open;

window.open = function (...args) {
    for (let i = 0; i < args.length; i++) {
      if (args[i] === '_blank') {
        args[i] = '_self';
      }
    }

    return orgOpen(...args); 
}