You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+2-2
Original file line number
Diff line number
Diff line change
@@ -10,12 +10,12 @@
10
10
11
11
I added the following tests:
12
12
13
-
*Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
13
+
*Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
14
14
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See [Test Coverage].*
15
15
16
16
## Checklist
17
17
18
-
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
18
+
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
19
19
20
20
-[ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
Copy file name to clipboardExpand all lines: CODE_OF_CONDUCT.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -44,6 +44,6 @@ an expert in all the systems. Once you find the answer, document it in
44
44
the first place you looked. That way, the next person will be brought
45
45
up to speed even quicker.
46
46
47
-

47
+

48
48
49
49
Source: _[xkcd, May 2012](https://xkcd.com/1053/)_
by the [luci/recipes-py github project](https://github.com/luci/recipes-py).
84
+
by the [luci/recipes-py GitHub project](https://github.com/luci/recipes-py).
85
85
86
86
The typical cycle for editing a recipe is:
87
87
88
-
1.Checkout the recipes project using `git clone https://flutter.googlesource.com/recipes`.
88
+
1.Check out the recipes project using `git clone https://flutter.googlesource.com/recipes`.
89
89
2. Make your edits (probably to files in
90
90
`//recipes/recipes`).
91
91
3. Update the tests. Run `recipes.py test train` to update
92
-
existing expected output to match the new output. Verify completely new test
92
+
the existing expected output to match the new output. Verify completely new test
93
93
cases by altering the `GenTests` method of the recipe. The recipe is required
94
94
to have 100% test coverage.
95
95
4. Run `led get-builder 'luci.flutter.prod:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
96
96
`GIT_HASH` is the hash to build (which is important for the engine but not
97
97
for the framework).
98
98
5. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
99
-
6. Upload the patch (`git commit`, `git cl upload`) and send it to someone in
99
+
6. Upload the patch (`git commit`, `git cl upload`), and send it to someone in
100
100
the `OWNERS` file for review.
101
101
102
102
### The infra config repository
@@ -112,7 +112,7 @@ schema that describes available properties.
112
112
113
113
### Future Directions
114
114
115
-
We would like to host our own recipes instead of storing them in
115
+
We would like to host our recipes instead of storing them in
0 commit comments