Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryData is not create and tracked in Configmap. #1774

Open
MengjiaLiang opened this issue Mar 9, 2025 · 0 comments
Open

BinaryData is not create and tracked in Configmap. #1774

MengjiaLiang opened this issue Mar 9, 2025 · 0 comments

Comments

@MengjiaLiang
Copy link

Describe the bug

Hi, not sure if it is a bug or an intentional thing.
The config tracker seems only to watch and promote the change on data for configmaps.
We are hitting a few issues when having the BinaryData section in the configmap.

  • Any changes in BinaryData will not trigger a canary analysis.
  • Any configmap promotion will remove the BinaryData in the primary configmap.

Could anyone please help to confirm this is a bug or a feature miss?
If so, I am more than happy to contribute on this. Thank you!

To Reproduce

  • Create a config map with both BinaryData and data. The BinaryData will not be created in the primary configmap.

Expected behavior

  • Any changes in BinaryData should also be monitored and promoted to the primary configmap.

A clear and concise description of what you expected to happen.

Additional context

  • Flagger version: I am using v1.37, but from the source code, I think it is on all versions.
@MengjiaLiang MengjiaLiang changed the title BinaryData is not create tracked in Configmap. BinaryData is not create and tracked in Configmap. Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant