Skip to content

Align structural reading evidence labels#64

Merged
flyingrobots merged 3 commits into
mainfrom
cycle/CORE_structural-history-evidence-label-alignment
Jun 1, 2026
Merged

Align structural reading evidence labels#64
flyingrobots merged 3 commits into
mainfrom
cycle/CORE_structural-history-evidence-label-alignment

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds the Slice 1 design packet for structural-history evidence label alignment.
  • Extends StructuralReadingPort evidence with the Graft taxonomy: echo-native, git-warp-imported, and fallback-translated.
  • Maps those Graft labels to the Wesley-generated StructuralEvidenceKind values.
  • Labels current git-warp structural-reading adapter evidence as fallback-translated while keeping nativeContinuumWitness: false.
  • Hardens structural evidence guards so malformed translated-substrate evidence cannot masquerade as Echo-native evidence.
  • Updates focused structural-reading tests, Graft publishing instructions, and the changelog.

Why

This is the first Graft-only pre-Echo slice after PR #63. The goal is to make evidence provenance explicit before runtime migration so current git-warp readings cannot be mistaken for future Echo-native evidence.

Validation

  • RED: pnpm exec vitest run test/unit/ports/structural-reading.test.ts failed on the malformed translated-substrate masquerade regression before the guard fix.
  • GREEN/VERIFY: pnpm exec vitest run test/unit/ports/structural-reading.test.ts test/unit/warp/structural-reading-adapter.test.ts passed 2 files / 8 tests.
  • pnpm lint passed.
  • pnpm typecheck passed.
  • pnpm test passed 224 files / 1639 tests.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 46 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 60559b32-3521-4c34-802c-8be86444e8eb

📥 Commits

Reviewing files that changed from the base of the PR and between 390033d and e2f692d.

⛔ Files ignored due to path filters (4)
  • AGENTS.md is excluded by !**/*.md
  • CHANGELOG.md is excluded by !**/*.md
  • docs/design/CORE_structural-history-evidence-label-alignment.md is excluded by !**/*.md
  • docs/method/backlog/asap/CORE_structural-history-evidence-label-alignment.md is excluded by !**/*.md
📒 Files selected for processing (4)
  • src/ports/structural-reading.ts
  • src/warp/structural-reading-adapter.ts
  • test/unit/ports/structural-reading.test.ts
  • test/unit/warp/structural-reading-adapter.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/CORE_structural-history-evidence-label-alignment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@flyingrobots flyingrobots marked this pull request as ready for review June 1, 2026 09:35
@flyingrobots flyingrobots changed the title [codex] Align structural reading evidence labels Align structural reading evidence labels Jun 1, 2026
@flyingrobots

Copy link
Copy Markdown
Owner Author

@codex Self-audit finding for PR #64.

Severity File Lines Issue Evidence Recommended mitigation
P2 src/ports/structural-reading.ts 149-158 Echo-native guard trusts evidenceLabel alone isContinuumNativeEvidence and isEchoNativeEvidence return true when evidence.evidenceLabel === "echo-native". A malformed translated-substrate object carrying that label could pass the guard, which weakens the slice invariant that current git-warp evidence cannot masquerade as Echo-native witnesshood. Add a regression test with a malformed translated-substrate object carrying echo-native; then make Echo-native guards require kind === "continuum-native", evidenceLabel === "echo-native", and nativeContinuumWitness === true. Tighten imported/fallback helpers to require translated-substrate shape and nativeContinuumWitness === false.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@flyingrobots

Copy link
Copy Markdown
Owner Author

Activity Summary

Issue Severity File Commit SHA Outcome
Echo-native evidence guard trusted evidenceLabel alone, allowing malformed translated-substrate evidence to masquerade as Echo-native P2 src/ports/structural-reading.ts, test/unit/ports/structural-reading.test.ts e2f692d3 Added deterministic RED regression, hardened Echo-native/imported/fallback guard checks, verified focused suites, lint, typecheck, and full test suite.

Validation:

  • RED: pnpm exec vitest run test/unit/ports/structural-reading.test.ts failed as expected before the fix.
  • GREEN/VERIFY: pnpm exec vitest run test/unit/ports/structural-reading.test.ts test/unit/warp/structural-reading-adapter.test.ts passed 2 files / 8 tests.
  • pnpm lint passed.
  • pnpm typecheck passed.
  • pnpm test passed 224 files / 1639 tests.

@flyingrobots flyingrobots merged commit c03c818 into main Jun 1, 2026
3 checks passed
@flyingrobots flyingrobots deleted the cycle/CORE_structural-history-evidence-label-alignment branch June 1, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant