Skip to content

v0.0.6 type-family parity projection#519

Merged
flyingrobots merged 1 commit into
mainfrom
release/v0.0.6-parity-projection
May 22, 2026
Merged

v0.0.6 type-family parity projection#519
flyingrobots merged 1 commit into
mainfrom
release/v0.0.6-parity-projection

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

@flyingrobots flyingrobots commented May 22, 2026

Summary

This PR defines the next v0.0.6 parity projection before broadening pnpm parity:ir beyond table-compatible SDL.

  • Adds docs/design/0013-rust-ir-parity-sentinel/SOURCE_type-family-parity-projection.md.
  • Names js-sdl-type-family-vs-rust-l1-type-family.v0 as the fair projection for schema-extension and non-table GraphQL facts.
  • Updates 0013, the fixture contract note, BEARING, design index, and CHANGELOG so schema-extensions-schema.graphql does not enter default parity on table evidence alone.

Why

schema-extensions-schema.graphql already passes the current js-table-vs-rust-table.v0 projection when run explicitly, but that proves only folded table facts. The legacy JS table adapter drops scalars, interfaces, unions, enums, input objects, and extension-folded non-table facts that Rust L1 retains. The next implementation needs a named projection for those facts before the default parity corpus expands.

Validation

  • pnpm run lint:docs-whitespace
  • node scripts/check-doc-links.mjs
  • git diff --check
  • pnpm parity:ir
  • pnpm parity:ir --fixture test/fixtures/ir-parity/schema-extensions-schema.graphql
  • pnpm run preflight
  • Push pre-push hook: repository preflight

Scope

No runtime behavior changed. No Echo, jedit, Continuum, git-warp, warp-ttd, or wesley-postgres files were touched.

Summary by CodeRabbit

  • Documentation
    • Added comprehensive design documentation for a new type-family validation framework
    • Updated project guidance on schema-extension handling criteria
    • Clarified validation specifications and implementation requirements

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c925baab-cc39-410a-873e-026be43a10e1

📥 Commits

Reviewing files that changed from the base of the PR and between d4d6e20 and ac9df8d.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • docs/BEARING.md
  • docs/design/0013-rust-ir-parity-sentinel/SOURCE_type-family-parity-projection.md
  • docs/design/0013-rust-ir-parity-sentinel/SOURCE_wesley-core-rs-ir-contract-and-fixtures.md
  • docs/design/0013-rust-ir-parity-sentinel/rust-ir-parity-sentinel.md
  • docs/design/README.md

📝 Walkthrough

Walkthrough

This PR documents a new type-family parity projection for validating GraphQL schema structures beyond table-compatible SDL. The core design specification, cross-references to related documents, and changelog entries establish how schema-extension fixtures will be gated on the projection's successful validation.

Changes

Type-Family Parity Projection Design

Layer / File(s) Summary
Type-Family Parity Projection Design Document
docs/design/0013-rust-ir-parity-sentinel/SOURCE_type-family-parity-projection.md
New design document specifying the js-sdl-type-family-vs-rust-l1-type-family.v0 projection for validating GraphQL type-family facts (scalars, objects, interfaces, unions, enums, input objects). Defines scope, included/excluded fact categories, normalization rules (folding extend blocks, deterministic sorting, directive handling, metadata exclusions), implementation shape (separate fixture keying and gating), playback questions, and non-goals.
Design Documentation Cross-References
docs/design/README.md, docs/design/0013-rust-ir-parity-sentinel/rust-ir-parity-sentinel.md, docs/design/0013-rust-ir-parity-sentinel/SOURCE_wesley-core-rs-ir-contract-and-fixtures.md
Updates existing design documents to reference the new type-family projection: README.md links the new sub-document, rust-ir-parity-sentinel.md adds a "Next Projection" section describing the projection and gating criteria for schema-extension admission, and SOURCE_wesley-core-rs-ir-contract-and-fixtures.md clarifies that schema-extension admission uses the Type-family parity projection.
Release Notes and Roadmap
CHANGELOG.md, docs/BEARING.md
CHANGELOG.md adds an [Unreleased] → Added entry announcing the projection. BEARING.md updates "Next Target" guidance to name the projection, confirm semantic lowering spans are absent, and gate schema-extensions-schema.graphql admission until the projection passes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A projection new, with care designed,
To catch the type-families we find,
The SDL structures side by side,
JS and Rust with nowhere to hide.
Schema extensions wait their turn,
Till parity facts are earned.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v0.0.6-parity-projection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🔍 The Case of Pull Request #519

Plain-English Readout

  • Holmes (evidence investigation): Holmes says this change should not ship in its current state. Main reasons: No evidence citations were available for trust analysis; test evidence is incomplete; schema coverage is incomplete.
  • Watson (independent verification): Watson found verification concerns. Most important concern: Low migration risk claimed but schema incomplete.
  • Moriarty (trend forecast): Moriarty sees progress as stalled right now, so forecast confidence is limited.

Suggested next actions

  1. Tighten citations so the report points to exact lines instead of whole files or coarse references.
  2. Resolve Watson’s verification concerns before trusting the Holmes verdict as final.
  3. Treat the readiness forecast as stalled until new evidence or real progress moves the trend again.
  4. Add or strengthen tests for the schema elements and operations HOLMES flagged as weakly proven.
📚 Glossary (what the Holmes terms mean)
  • HOLMES: Wesley’s main evidence investigation. It decides whether the cited proof is strong enough to justify shipping this commit.
  • WATSON: An independent verification pass. It checks Holmes’s citations and score math instead of trusting them blindly.
  • MORIARTY: A readiness forecast over time. It is advisory trend analysis, not the release gate itself.
  • Schema coverage score (SCS): How much of the schema has direct supporting evidence across generated artifacts and cited proof.
  • Test confidence index (TCI): How much test evidence exists for constraints, policies, relationships, and operations.
  • Migration risk index (MRI): How risky the schema change is to roll out. Lower is better.
  • Evidence trust: Whether the report is backed by exact citations, whole-file citations, or coarse references. Weak trust means the claim may be directionally right but not specific enough to trust blindly.
  • Citation quality: A count of exact line-span citations versus whole-file or coarse references.
  • ELEMENTARY: Ready to ship based on the current evidence.
  • REQUIRES INVESTIGATION: More work or review is needed before shipping.
  • YOU SHALL NOT PASS: Do not ship this change in its current state.

🕵️ SHA-lock HOLMES full report (click to expand)

🕵️ SHA-lock HOLMES Investigation

  • Generated: 2026-05-22T22:50:12.514Z
  • Commit SHA: ff1a599
  • Bundle Version: 2.0.0

⚠️ Evidence valid only for commit ff1a599

🔍 Executive Deduction

"Watson, after careful examination of the evidence, I deduce..."

Weighted Completion: ░░░░░░░░░░ 0.0%
Scores: SCS 0.0% · TCI 0.0% · MRI 0.0%
Verification Status: 0 claims verified
Citation Quality: 0 exact · 0 whole-file · 0 coarse
Evidence Trust: missing
Ship Verdict: YOU SHALL NOT PASS

🧩 SCS Breakdown

Component Score Coverage
Sql 0.0% 0.00/154.00
Types 0.0% 0.00/154.00
Validation 0.0% 0.00/154.00
Tests 0.0% 0.00/154.00

🧪 TCI Breakdown

Component Score Coverage Note
Unit Constraints 0.0% 0/104 N/A
Unit Rls 0.0% N/A
Integration Relations 0.0% 0/3 N/A
E2e Ops N/A Query operation test tracking not yet implemented

⚠️ MRI Breakdown

Component Risk Share Points Count
Drops 0% 0 0
Renames Without Uid 0% 0 0
Add Not Null Without Default 0% 0 0
Non Concurrent Indexes 0% 0 0

📊 The Weight of Evidence

"Observe, Watson, how not all features carry equal importance..."

Element Weight Status Evidence Strength Deduction

🚪 Security & Performance Gates

"Elementary security measures, Watson..."

Gate Status Evidence Holmes's Ruling
Migration Risk MRI: 0.0% "Trivial risk"
Test Coverage ⚠️ TCI: 0.0% "Theatrical tests!"
Sensitive Fields 0 fields "All secured"
Evidence Quality 0 exact · 0 whole-file · 0 coarse "No evidence citations were available for trust analysis."

📋 The Verdict

YOU SHALL NOT PASS
"Critical evidence is missing! Return to your laboratory!"

Signed and sealed,

  • S. Holmes, Consulting Detective

[END OF INVESTIGATION FOR COMMIT ff1a599]

🧵 Command Run

  • Run ID: run-mphijn9g-8ub5sq
  • Transmutation: holmes-investigate
  • Command: investigate
  • Status: completed
  • Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

🩺 Dr. WATSON full report (click to expand)

🩺 Dr. Watson's Independent Verification Report

Medical Examination of Evidence

  • Examination Date: 2026-05-22T22:51:10.504Z
  • Patient SHA: ff1a599

🔬 Citation Verification

"Let me examine each piece of evidence independently..."

  • Citations Examined: 0
  • Verified: 0 ✅
  • Failed: 0 ❌
  • Unable to Verify: 0
  • Exact Subrange Citations: 0
  • Whole-file Citations: 0
  • Coarse Citations: 0
  • Evidence Trust: missing
  • Trust Note: No evidence citations were available for trust analysis.

Verification Rate: 0.0%

📊 Mathematical Verification

"I shall recalculate Holmes's arithmetic..."

Holmes claimed SCS: 0.0%
Watson calculates: 0.0%
Difference: ✅ Negligible

🔍 Consistency Analysis

"Checking for contradictions in Holmes's deductions..."

⚠️ Low migration risk claimed but schema incomplete

🩺 Dr. Watson's Medical Opinion

VERIFICATION: CONCERNS NOTED ⚠️

"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."

Respectfully submitted,

  • Dr. J. Watson, M.D.
    Medical Examiner & Verification Specialist

🧵 Command Run

  • Run ID: run-mphik8bh-r7w4t8
  • Transmutation: watson-verify
  • Command: verify
  • Status: completed
  • Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

🔮 Professor MORIARTY full report (click to expand)

🧠 Professor Moriarty's Temporal Predictions

The Mathematics of Inevitability

  • Analysis Date: 2026-05-22T22:51:43.344Z

🔮 Current State

SCS: ░░░░░░░░░░ 0.0%
TCI: ░░░░░░░░░░ 0.0%
MRI: 0.0% risk
Evidence Trust: missing

📈 Velocity Analysis

SCS Velocity: +0.00%/day
Git Activity (window): 24h · commits 13 (1 relevant) · ~13.00 commits/day
↳ Magnitude: ~313 relevant LOC/day across ~6.0 files/day
Activity Index: 25 / 100 (PR 0, Window 62)
Blended Velocity: +0.15%/day
Commit Size Burstiness: 0 / 100 (higher = more uneven commit sizes)
⚠️ PLATEAU DETECTED - Low SCS movement and low recent Git activity.

⏰ Completion Predictions

ETA: Cannot predict (insufficient velocity)

"At current velocity, completion is... improbable."

⚠️ Warnings

  • Evidence trust is missing; No evidence citations were available for trust analysis.

🧪 Readiness EXPLAIN

  • SCS ≥ 80% → FAIL ❌ (actual 0.0%)
  • TCI ≥ 70% → FAIL ❌ (actual 0.0%)
  • MRI ≤ 40% → PASS ✅ (actual 0.0%)
  • CI Stability ≥ 90% (branch main) → PASS ✅ (actual 91% over ~168h)
  • Evidence Trust ≥ moderate → FAIL ❌ (actual missing) — No evidence citations were available for trust analysis.
  • Delivery context (last 168h): 0 issues closed · 7 PRs merged (informational, not gating)

Signals blend: SCS velocity (70%) + Git activity (30%, branch-first). Activity only suppresses false plateaus; it never inflates readiness.

📊 Historical Trajectory

05-22: ░░░░░░░░░░ 0.0%
05-22: ░░░░░░░░░░ 0.0%
05-22: ░░░░░░░░░░ 0.0%

"Every problem becomes elementary when reduced to mathematics"
— Professor Moriarty

🧵 Command Run

  • Run ID: run-mphikxny-8e6eum
  • Transmutation: moriarty-predict
  • Command: predict
  • Status: completed
  • Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger

Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).


Filed at 221B Repository Street

@flyingrobots flyingrobots marked this pull request as ready for review May 22, 2026 23:14
@flyingrobots flyingrobots merged commit 05ec1ec into main May 22, 2026
22 of 23 checks passed
@flyingrobots flyingrobots deleted the release/v0.0.6-parity-projection branch May 22, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant