Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add support for passing env variables to flyteadmin using envFrom #5216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ctso
Copy link

@ctso ctso commented Apr 10, 2024

Tracking issue

Related to #3970

Why are the changes needed?

Users may want to pass environment variables from Secrets or ConfigMaps instead of relying on the Helm chart's flyteadmin.secrets Helm value. This is convenient when using a secrets manager such as External Secrets, for example.

What changes were proposed in this pull request?

Add a new Helm value, flyteadmin.envFrom which you can pass through directly to the underlying Deployment.

How was this patch tested?

Tested locally using helm template, it works.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented Apr 10, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Apr 10, 2024
@ctso ctso force-pushed the ctso/flyte-core-chart-envfrom branch from 1cd6313 to 9ff19da Compare April 10, 2024 22:56
charts/flyte-core/templates/admin/deployment.yaml Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 11, 2024
Signed-off-by: Chris Soyars <[email protected]>
@ctso ctso force-pushed the ctso/flyte-core-chart-envfrom branch from fae3f59 to acf00e7 Compare April 11, 2024 15:34
@wild-endeavor
Copy link
Contributor

Should we match

?

@wild-endeavor
Copy link
Contributor

@ctso I think it would feel nicer if at least the value var names matched between single binary and flyte-core. yah?

@davidmirror-ops
Copy link
Contributor

@ctso what are we missing to ship this? There are users dealing with limitations where this feature would be helpful

@ctso
Copy link
Author

ctso commented Sep 13, 2024

I think this could be merged as-is, though it sounds like maybe we want to update the single binary chart to have the same behavior as well?

@davidmirror-ops
Copy link
Contributor

@wild-endeavor not sure I follow, what you mean is matching in flyte-core the way this section enables envVars from different sources?

envFrom:
{{- if .Values.deployment.extraEnvVarsConfigMap }}
- configMapRef:
name: {{ .Values.deployment.extraEnvVarsConfigMap }}
{{- end }}
{{- if .Values.deployment.extraEnvVarsSecret }}
- secretRef:
name: {{ .Values.deployment.extraEnvVarsSecret }}
{{- end }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants