Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve monorepo setup #57

Closed
3 of 4 tasks
jevakallio opened this issue Jul 5, 2020 · 1 comment
Closed
3 of 4 tasks

Improve monorepo setup #57

jevakallio opened this issue Jul 5, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jevakallio
Copy link
Collaborator

jevakallio commented Jul 5, 2020

Last night I migrated all the foam packages (save for foam-template) to a monorepo structure. There are a couple of issues that need to be resolved:

  • Workspace tasks for running common development workflows
  • foam-vscode and foam-cli should use local foam-workspace-manager in development
  • vsce package does not know how to pick up packages from hoisted yarn workspaces
    • Currently worked around by running vsce package with npm install. See d6d31fa
  • Migrate all packages to test with jest

Help wanted with remaining issues!

Materials

https://medium.com/@rossbulat/typescript-working-with-paths-packages-and-yarn-workspaces-6fbc7087b325

@jevakallio jevakallio added the enhancement New feature or request label Jul 5, 2020
@jevakallio jevakallio added the help wanted Extra attention is needed label Jul 11, 2020
@riccardoferretti
Copy link
Collaborator

per my conversation with @jevakallio, this is currently blocked by microsoft/vscode-vsce#493 - and will be tracked in #314 - so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants