bug: `plugin` and `pattern` is mutually exclusive for icons.rules

[MunifTanjim]

Did you check docs and existing issues?

• I have read all the which-key.nvim docs
• I have updated the plugin to the latest version before submitting this issue
• I have searched the existing issues of which-key.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.12.0-dev-1134+g79bfeecdb4-Homebrew

Operating system/version

MacOS

Describe the bug

which-key.nvim/lua/which-key/icons.lua

Line 22 in 3aab214

{ plugin = "telescope.nvim", pattern = "telescope", icon = "", color = "blue" },

Having both plugin and pattern for an icon rule doesn't combine them. If plugin exists, pattern is completely ignored.

which-key.nvim/lua/which-key/icons.lua

Lines 152 to 157 in 3aab214

	if icon.plugin == plugin then
	local ico, hl = M.get_icon(icon)
	if ico then
	return ico, hl
	end
	end

Steps To Reproduce

    icons = {
      rules = {
        { plugin = "claudecode.nvim", icon = "" },
        { plugin = "claudecode.nvim", pattern = "toggle", icon = "󰨚", color = "yellow" },
      },
    },

Expected Behavior

I want diffrent keymaps inside claudecode.nvim to have different icons and also claudecode.nvim group itself to have an icon.

Health

Log

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/which-key.nvim", opts = {} },
    -- add any other plugins here
  },
})

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[MunifTanjim]

Not stale.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[MunifTanjim]

Bad bot. Not stale.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[disrupted]

not stale

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.