Skip to content

Commit 52821ba

Browse files
borisbatclaude
andcommitted
pages.yml: actually install Emscripten before building WASM
web/step0_emsdk_install.sh is a one-liner that just clones the emsdk wrapper repo. The toolchain itself — emsdk/upstream/emscripten/, which the cmake -DCMAKE_TOOLCHAIN_FILE arg points at — lands via the install+activate pair that step1_emsdk_activate_linux.sh does locally. pages.yml was calling step0 but never the install/activate steps, so the WASM build always failed at cmake-configure ("Could not find toolchain file"). continue-on-error: true on this step paints it green in the run summary, and the post-build staging silently skipped the missing-artifact copies — until the round-5 placeholder gate started serving the "Runtime rebuild in progress" page instead, which is what surfaced this. Add the two missing commands. The build should now actually produce web/output/daslang_static.{js,wasm}; the existing staging gate will then take the real path instead of the placeholder. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent e49e6f3 commit 52821ba

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/pages.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,14 @@ jobs:
7777
run: |
7878
set -eux
7979
cd web
80+
# step0 only clones the emsdk wrapper — the toolchain itself
81+
# (emsdk/upstream/emscripten/) lands via the install+activate pair
82+
# that web/step1_emsdk_activate_linux.sh does locally. Without these,
83+
# cmake's -DCMAKE_TOOLCHAIN_FILE points at a path that doesn't
84+
# exist yet and the WASM build silently fails under continue-on-error.
8085
bash step0_emsdk_install.sh
81-
# step1 sources emsdk_env.sh — re-export EMSDK for the configure step
86+
./emsdk/emsdk install latest
87+
./emsdk/emsdk activate latest
8288
bash -c "source emsdk/emsdk_env.sh && \
8389
mkdir -p build && cd build && \
8490
cmake -DCMAKE_BUILD_TYPE=Release -G Ninja \

0 commit comments

Comments
 (0)