Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAME: a library for atomistic modeling environments was added. #525

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

alirezagh76
Copy link
Contributor

FLAME: a library for atomistic modeling environments was added.

FLAME: a library for atomistic modeling environments was added.
Copy link
Member

@ivan-pi ivan-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alireza,

thanks for the PR. I think with my modifications the package could be included in the index. Maybe you can have a look also at the extra recommended-only criteria:
https://fortran-lang.org/community/packages/#package-criteria

I found your documentation page is hosted on GitLab: https://flame-code.gitlab.io/FLAME/index.html; maybe you could link it to the README? The documentation also links to the GitHub mirror (https://github.com/flame-code/FLAME), however that one was last updated three years ago.

Copy link
Member

@ivan-pi ivan-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for some additional reviews then. (@perazz maybe?)

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alirezagh76 , it looks good to me, maybe you could just look for a few more tags to add.

@alirezagh76
Copy link
Contributor Author

Thanks @alirezagh76 , it looks good to me, maybe you could just look for a few more tags to add.

Thanks! I corrected the previous tags and added a new new.

@henilp105
Copy link
Member

Thanks @alirezagh76 , I have just made a few format changes , merging.

@henilp105 henilp105 merged commit f7b3514 into fortran-lang:main Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants