-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLAME: a library for atomistic modeling environments was added. #525
Conversation
FLAME: a library for atomistic modeling environments was added.
Co-authored-by: Ivan Pribec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Alireza,
thanks for the PR. I think with my modifications the package could be included in the index. Maybe you can have a look also at the extra recommended-only criteria:
https://fortran-lang.org/community/packages/#package-criteria
I found your documentation page is hosted on GitLab: https://flame-code.gitlab.io/FLAME/index.html; maybe you could link it to the README? The documentation also links to the GitHub mirror (https://github.com/flame-code/FLAME), however that one was last updated three years ago.
Co-authored-by: Ivan Pribec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for some additional reviews then. (@perazz maybe?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alirezagh76 , it looks good to me, maybe you could just look for a few more tags to add.
Thanks! I corrected the previous tags and added a new new. |
Thanks @alirezagh76 , I have just made a few format changes , merging. |
FLAME: a library for atomistic modeling environments was added.