Skip to content

Commit 05f57d5

Browse files
authored
Merge pull request #13 from forumone/upgrade-nextjs-13
Upgrade nextjs 13
2 parents ae43937 + 1d65022 commit 05f57d5

File tree

3 files changed

+1164
-930
lines changed

3 files changed

+1164
-930
lines changed

README.project.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,17 @@ This is a starter app for [Next.js](https://nextjs.org/) (bootstrapped with [`cr
66
* [ESLint](https://eslint.org/)
77
* [Prettier](https://prettier.io/)
88

9-
Note that Next v11 comes with the following installed already:
9+
Note that Next v13 comes with the following installed already:
1010
* [Webpack v5](https://webpack.js.org/concepts/)
11-
* [Babel v7](https://babeljs.io/docs/en/)
1211

1312
## Getting Started
1413

1514
## Initial Setup
1615

16+
1. Setup [husky](https://typicode.github.io/husky/#/) by installing it at the base of the repo.
17+
```bash
18+
npm ci
19+
```
1720

1821
1. Go to the `services/app` directory.
1922
```bash
@@ -39,7 +42,7 @@ Note that Next v11 comes with the following installed already:
3942
1. Now you are ready to start up the app. To do that, run `ddev start` from within the `services/app` directory:
4043
```bash
4144
ddev start
42-
```
45+
```
4346

4447
## Starting and stopping the project
4548

@@ -148,16 +151,15 @@ with the option to include a Storybook story file as well.
148151
## Notes
149152

150153
* Code for the app is currently configured to go into the `pages` directory (for [Next.js pages](https://nextjs.org/docs/basic-features/pages)) and `source` for theming, components, providers, helpers, etc.
151-
* Starting in Next.js v9.4, TypeScript errors do not show up in your browser when running the dev server (i.e. `npm run dev`). However, TS errors will prevent `next build` (i.e. `npm run build`) from running successfully. Be sure to run `npm run lint` and `npm run tsc` before committing and pushing code. This will give you lint and TS errors that will most likely cause your builds to fail.
152-
* For discussion: should we include a [TS checker in the config](https://github.com/vercel/next.js/issues/12735#issuecomment-629404102)? Note that a Next.js dev warns that [this will greatly slow development](https://github.com/vercel/next.js/issues/12735#issuecomment-629404842).
154+
* Starting in Next.js v9.4, TypeScript errors do not show up in your browser when running the dev server (i.e. `npm run dev`). However, TS errors will prevent `next build` (i.e. `npm run build`) from running successfully. You can run `npm run lint` and `npm run tsc` to check for issues, which will give you lint and TS errors that will most likely cause your builds to fail. Note also that if you have [`husky`](https://typicode.github.io/husky/#/) installed, these will automatically run when you attempt to commit to a branch.
153155
* The current favicon implementation will probably not display correctly locally in Chrome (v94), but does display correctly in Firefox and Safari. Note that the favicon _does_ display correctly once deployed. Not sure why.
154156

155157

156158
## Helpful tips
157159

158160
### Starting project is slow
159161

160-
If the npm install is running slow you can enable `mutagen`, to do this:
162+
If the npm install is running slow you can enable `mutagen`, to do this:
161163
* In the `.ddev` folder create a file named: `config.mutagen.yaml`
162164
* In the file place: `mutagen_enabled: true`
163165
* Please Restart the project.

0 commit comments

Comments
 (0)