Skip to content

Conversation

@krishmishra846-alt
Copy link
Contributor

@krishmishra846-alt krishmishra846-alt commented Nov 25, 2025

Fixes: #1154

Description:
As per the issue, the "Create Event" page had unstable options for selecting Ticket/Talk/Video components and Event Series.
This PR hides these options from the UI to simplify the event creation process.

Changes Made:

  • Commented out the "Create this event for" section in create_foundation.html.
  • Commented out the "Video Platform" checkbox.
  • Commented out the "Event Series" option.
  • Ensured the "Organizer" and "Singular Event" options remain visible.

Screenshots:
(See below)

Screenshot 2025-11-25 122719 Screenshot 2025-11-25 122719

Summary by Sourcery

Hide unstable event component options on the Create Event page and adjust related configuration and messaging.

Bug Fixes:

  • Hide unstable Ticket/Talk/Video and Event Series options from the Create Event form to prevent use of unsupported flows.

Enhancements:

  • Update the presale landing page greeting text to reference GSOC 2026.

Deployment:

  • Point Redis backend and broker configuration to localhost for the eventyay instance.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR hides unstable event component selection options on the Create Event page by commenting out related UI sections, while keeping organizer and singular event selection visible, but it also includes non‑described changes to configuration (Redis endpoints) and a greeting text change on the presale index page that may be unintended.

File-Level Changes

Change Details Files
Hide unstable component selection options on the Create Event (foundation) form while keeping necessary fields visible.
  • Wrap the entire 'Create this event for' form-group in an HTML comment so it no longer renders in the UI.
  • Comment out the video platform checkbox by moving the closing HTML comment to immediately after the is_video_creation field.
  • Comment out the 'Event Series' big-radio option by starting an HTML comment on the series radio container div and misplacing the closing comment after the descriptive text div, effectively hiding the radio but not the help text.
  • Ensure the organizer field and event type selection remain rendered as before.
app/eventyay/eventyay_common/templates/eventyay_common/events/create_foundation.html
Modify Redis configuration to point to localhost instances instead of the eventyay-next-redis host.
  • Change redis.location from redis://eventyay-next-redis/0 to redis://localhost/0.
  • Change Celery backend from redis://eventyay-next-redis/1 to redis://localhost/1.
  • Change Celery broker from redis://eventyay-next-redis/2 to redis://localhost/2.
app/eventyay.cfg
Change the greeting text on the presale index page, likely as a temporary or debug modification.
  • Replace the translated 'Hello!' heading with a hard-coded '"HEllO GSOC 2026!"' string, removing i18n support for that text.
app/eventyay/presale/templates/pretixpresale/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The template changes comment out substantial chunks of markup including only parts of some radio blocks (e.g., the event series radio) which may leave dangling or mismatched container elements; consider removing or fully encapsulating these sections in comments/conditionals instead of partially commenting tags to avoid layout or rendering issues.
  • The changes in eventyay.cfg switch Redis backend/broker locations from the cluster hostname to localhost, which looks like an environment-specific tweak and should either be reverted or moved to a local override config so it doesn’t affect other deployments.
  • Updating the landing page heading text to a hard-coded, quoted string removes the translation tag and introduces literal quotes in the UI; if this change is intentional, keep the trans/blocktrans usage and avoid inline quotes so that the text remains localizable and consistent with the rest of the template.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The template changes comment out substantial chunks of markup including only parts of some radio blocks (e.g., the event series radio) which may leave dangling or mismatched container elements; consider removing or fully encapsulating these sections in comments/conditionals instead of partially commenting tags to avoid layout or rendering issues.
- The changes in eventyay.cfg switch Redis backend/broker locations from the cluster hostname to localhost, which looks like an environment-specific tweak and should either be reverted or moved to a local override config so it doesn’t affect other deployments.
- Updating the landing page heading text to a hard-coded, quoted string removes the translation tag and introduces literal quotes in the UI; if this change is intentional, keep the trans/blocktrans usage and avoid inline quotes so that the text remains localizable and consistent with the rest of the template.

## Individual Comments

### Comment 1
<location> `app/eventyay/presale/templates/pretixpresale/index.html:7` </location>
<code_context>
 {% block content %}
     <div class="form-signin" action="" method="post">
-        <h3>{% trans "Hello!" %}</h3>
+        <h3>"HEllO GSOC 2026!"</h3>
         <p>
             {% blocktrans trimmed with a_attr="href='https://eventyay.com'" %}
</code_context>

<issue_to_address>
**issue (bug_risk):** The new heading text removes translation support and introduces odd quoting/casing.

The previous `{% trans "Hello!" %}` was correctly wired into i18n. The new literal `"HEllO GSOC 2026!"` drops localization, uses inconsistent casing, and will display the extra quotes in the UI. If this isn’t just a temporary placeholder, please restore `{% trans %}` with an appropriate message id and remove the extra quotes so the heading stays localizable and looks intentional.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

{% block content %}
<div class="form-signin" action="" method="post">
<h3>{% trans "Hello!" %}</h3>
<h3>"HEllO GSOC 2026!"</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The new heading text removes translation support and introduces odd quoting/casing.

The previous {% trans "Hello!" %} was correctly wired into i18n. The new literal "HEllO GSOC 2026!" drops localization, uses inconsistent casing, and will display the extra quotes in the UI. If this isn’t just a temporary placeholder, please restore {% trans %} with an appropriate message id and remove the extra quotes so the heading stays localizable and looks intentional.

@mariobehling mariobehling requested a review from Sak1012 November 28, 2025 15:16
@Sak1012
Copy link
Member

Sak1012 commented Nov 28, 2025

Please Cherry Pick and remove the unnecessary commits.

Copy link
Contributor

@Saksham-Sirohi Saksham-Sirohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Hi, your changes seem to break the UI, as you can clearly see here. Please fix this also, some event types seem not to be visible, please fix that as well

@krishmishra846-alt
Copy link
Contributor Author

krishmishra846-alt commented Nov 29, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants