-
Notifications
You must be signed in to change notification settings - Fork 138
fix: Hide unstable component selection options in Create Event page #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR hides unstable event component selection options on the Create Event page by commenting out related UI sections, while keeping organizer and singular event selection visible, but it also includes non‑described changes to configuration (Redis endpoints) and a greeting text change on the presale index page that may be unintended. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The template changes comment out substantial chunks of markup including only parts of some radio blocks (e.g., the event series radio) which may leave dangling or mismatched container elements; consider removing or fully encapsulating these sections in comments/conditionals instead of partially commenting tags to avoid layout or rendering issues.
- The changes in eventyay.cfg switch Redis backend/broker locations from the cluster hostname to localhost, which looks like an environment-specific tweak and should either be reverted or moved to a local override config so it doesn’t affect other deployments.
- Updating the landing page heading text to a hard-coded, quoted string removes the translation tag and introduces literal quotes in the UI; if this change is intentional, keep the trans/blocktrans usage and avoid inline quotes so that the text remains localizable and consistent with the rest of the template.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The template changes comment out substantial chunks of markup including only parts of some radio blocks (e.g., the event series radio) which may leave dangling or mismatched container elements; consider removing or fully encapsulating these sections in comments/conditionals instead of partially commenting tags to avoid layout or rendering issues.
- The changes in eventyay.cfg switch Redis backend/broker locations from the cluster hostname to localhost, which looks like an environment-specific tweak and should either be reverted or moved to a local override config so it doesn’t affect other deployments.
- Updating the landing page heading text to a hard-coded, quoted string removes the translation tag and introduces literal quotes in the UI; if this change is intentional, keep the trans/blocktrans usage and avoid inline quotes so that the text remains localizable and consistent with the rest of the template.
## Individual Comments
### Comment 1
<location> `app/eventyay/presale/templates/pretixpresale/index.html:7` </location>
<code_context>
{% block content %}
<div class="form-signin" action="" method="post">
- <h3>{% trans "Hello!" %}</h3>
+ <h3>"HEllO GSOC 2026!"</h3>
<p>
{% blocktrans trimmed with a_attr="href='https://eventyay.com'" %}
</code_context>
<issue_to_address>
**issue (bug_risk):** The new heading text removes translation support and introduces odd quoting/casing.
The previous `{% trans "Hello!" %}` was correctly wired into i18n. The new literal `"HEllO GSOC 2026!"` drops localization, uses inconsistent casing, and will display the extra quotes in the UI. If this isn’t just a temporary placeholder, please restore `{% trans %}` with an appropriate message id and remove the extra quotes so the heading stays localizable and looks intentional.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| {% block content %} | ||
| <div class="form-signin" action="" method="post"> | ||
| <h3>{% trans "Hello!" %}</h3> | ||
| <h3>"HEllO GSOC 2026!"</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The new heading text removes translation support and introduces odd quoting/casing.
The previous {% trans "Hello!" %} was correctly wired into i18n. The new literal "HEllO GSOC 2026!" drops localization, uses inconsistent casing, and will display the extra quotes in the UI. If this isn’t just a temporary placeholder, please restore {% trans %} with an appropriate message id and remove the extra quotes so the heading stays localizable and looks intentional.
|
Please Cherry Pick and remove the unnecessary commits. |
Saksham-Sirohi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Noted
…On Sat, Nov 29, 2025, 2:10 AM Saksham Sirohi ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Screenshot.2025-11-29.at.2.07.09.AM.png (view on web)
<https://github.com/user-attachments/assets/fbe40037-b213-4109-8307-dd540243c71f>
Hi, your changes seem to break the UI, as you can clearly see here. Please
fix this also, some event types seem not to be visible, please fix that as
well
—
Reply to this email directly, view it on GitHub
<#1345 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWNNTEBBYE5CWRQH6B7ZS2337CXKFAVCNFSM6AAAAACNDOWQFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMJZHE3DGMBSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|

Fixes: #1154
Description:
As per the issue, the "Create Event" page had unstable options for selecting Ticket/Talk/Video components and Event Series.
This PR hides these options from the UI to simplify the event creation process.
Changes Made:
create_foundation.html.Screenshots:
(See below)
Summary by Sourcery
Hide unstable event component options on the Create Event page and adjust related configuration and messaging.
Bug Fixes:
Enhancements:
Deployment: