fix: correct comment for Git::has_submodules and remove_contract #12530
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashass1315
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
requested changes
Nov 13, 2025
crates/cli/src/utils/cmd.rs
Outdated
| /// Given a `Project`'s output, finds the contract by path and name and returns its | ||
| /// ABI, creation bytecode, and `ArtifactId`. | ||
| #[track_caller] | ||
| pub fn remove_contract( |
Contributor
There was a problem hiding this comment.
please also rename the function.
Contributor
Author
There was a problem hiding this comment.
please also rename the function.
Did it ser, thank you for your review
onbjerg
requested changes
Nov 13, 2025
Contributor
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
code needs to be formatted with rustfmt nightly otherwise lgtm
Contributor
Author
did it, sorry for inconvenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remove_contract doc suggested mutation and returning runtime bytecode, but the function only searched and returned ABI + creation bytecode + ArtifactId.
The Git::has_submodules docstring incorrectly stated that has_submodules() returns true when there are no submodules. The implementation returns true when git submodule status produces at least one line, i.e., when submodules exist.