Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attendance Link Not Updating Correctly in Employee Checkin. #2884

Open
1 task done
sowmyarajshree opened this issue Mar 19, 2025 · 0 comments
Open
1 task done

Attendance Link Not Updating Correctly in Employee Checkin. #2884

sowmyarajshree opened this issue Mar 19, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@sowmyarajshree
Copy link

sowmyarajshree commented Mar 19, 2025

Information about bug

When Attendance is created based on Employee Checkins, it correctly maps to the respective Checkins. However, two issues arise during cancellation and amendment:

Attendance Not Relinking on Amendment

  1. When Attendance is canceled, the attendance field in Employee Checkin is unlinked (which is expected).
  2. However, when the canceled Attendance is amended and submitted again, it does not relink to the corresponding Checkins, leading to incorrect attendance tracking.

Skip Auto Attendance Check Not Verified on Cancellation

  1. When canceling an Attendance record, the system does not automatically check the "Skip Auto Attendance" flag.
  2. If this checkbox is not manually marked, and Attendance is later recreated via a cron job, it gets incorrectly mapped to multiple Checkins, causing data inconsistencies.

Steps to Reproduce:

  1. Create an Attendance record based on Employee Checkins.
  2. Verify that the attendance field in Employee Checkin is correctly linked.
  3. Cancel the Attendance and confirm:
  • The attendance field in Employee Checkin is unlinked (expected behavior).
  • The Skip Auto Attendance flag remains unchecked (incorrect behavior).
  1. Amend the canceled Attendance and submit it again.
  2. Observe that:
  • The attendance field in Employee Checkin remains unlinked (should relink).
  • If Attendance is recreated via cron.

Expected Behavior:

  1. When Attendance is amended and submitted, it should correctly relink to Employee Checkins.
  2. When Attendance is canceled, the system should automatically check "Skip Auto Attendance" to prevent incorrect cron-based mappings.

Impact:
Incorrect Attendance tracking due to missing links after amendments.
Duplicate/multiple mappings when Attendance is recreated via cron.
Payroll and reporting issues caused by inaccurate Employee Checkin data.

Suggested Fix:
✅ Ensure that when Attendance is amended and submitted, it updates the attendance field in Employee Checkin.
✅ Modify the cancellation logic to automatically check "Skip Auto Attendance" to prevent incorrect mappings.

Module

HR

Version

Frappe HR Version - 15.41.0

Installation method

None

Relevant log output / Stack trace / Full Error Message.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@sowmyarajshree sowmyarajshree added the bug Something isn't working label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant