Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade six to latest for Python 3.13 #2385

Open
legoktm opened this issue Feb 11, 2025 · 2 comments · May be fixed by #2387
Open

Upgrade six to latest for Python 3.13 #2385

legoktm opened this issue Feb 11, 2025 · 2 comments · May be fixed by #2387
Assignees
@legoktm

Comments

@legoktm
Copy link
Member

legoktm commented Feb 11, 2025

Description

The current version of six has a bug that prevents usage in Python 3.13, so upgrade to the latest version, which currently is 1.17.0.

This should be pretty small and can be done first before any other 3.13/trixie work since it's compatible with 3.11/bookworm.
@legoktm
Copy link
Member Author

legoktm commented Feb 11, 2025

Upgrading six to 1.16.0 should be good enough, and that's what we've already diff reviewed in https://github.com/freedomofpress/securedrop-builder/wiki/six-1.15.0-to-1.16.0

Reading https://github.com/benjaminp/six/blob/main/CHANGES, the fixes in 1.17.0 don't affect us.

legoktm added a commit that referenced this issue Feb 11, 2025
@legoktm
Upgrade six to 1.16.0
8490643 
Was already reviewed in
<https://github.com/freedomofpress/securedrop-builder/wiki/six-1.15.0-to-1.16.0>.

Fixes #2385.
@legoktm legoktm mentioned this issue Feb 11, 2025
Open
1 task
legoktm added a commit that referenced this issue Feb 11, 2025
@legoktm
Upgrade six to 1.16.0
6c0a257 
Was already reviewed in
<https://github.com/freedomofpress/securedrop-builder/wiki/six-1.15.0-to-1.16.0>.

Wheel is added to builder in <freedomofpress/securedrop-builder#510>.

Fixes #2385.
@legoktm legoktm linked a pull request Feb 11, 2025 that will close this issue
Open
1 task
@legoktm legoktm self-assigned this Feb 11, 2025
@legoktm legoktm moved this to In Progress in SecureDrop dev cycle Feb 11, 2025
@legoktm
Copy link
Member Author

legoktm commented Feb 11, 2025

I went a little crazy and tried to create 4 interdependent PRs across builder and client; I've made it just 2, one in builder that needs to go first, and then the one in client. phew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legoktm legoktm

Labels
None yet
Projects
SecureDrop dev cycle
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade six to 1.16.0; drop 3.9 hashes freedomofpress/securedrop-client
1 participant
@legoktm