Increase Capacity Batch limit from 2 -> 10 (#1633)

# Goal
The goal of this PR is to increase the limit on capacity batches from 2
-> 10

Closes #1628

# Discussion
Why? 2 was set originally to be initially careful with how many were
allowed. With additional testing, it is clear there is no reason to not
increase to at least 10. In think in the end we'll be able to increase
to higher, but going slow.

# Checklist
- [x] Weights updated

---------

Co-authored-by: Frequency CI [bot] <[email protected]>

Author: wilwade

pallets/frequency-tx-payment/src/tests/mock.rs

@@ -103,7 +103,7 @@ impl pallet_balances::Config for Test {
 }
 
 pub type MaxSchemaGrantsPerDelegation = ConstU32<30>;
-pub type MaximumCapacityBatchLength = ConstU8<2>;
+pub type MaximumCapacityBatchLength = ConstU8<10>;
 
 pub struct TestAccountId;
 impl Convert<u64, AccountId> for TestAccountId {

pallets/frequency-tx-payment/src/tests/pallet_tests.rs

@@ -751,6 +751,14 @@ fn pay_with_capacity_batch_all_errors_when_transaction_amount_exceeds_maximum()
 				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
 				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
 				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
+				RuntimeCall::Balances(BalancesCall::transfer { dest: 2, value: 100 }),
 			];
 			assert_noop!(
 				FrequencyTxPayment::pay_with_capacity_batch_all(

pallets/frequency-tx-payment/src/weights.rs

@@ -18,9 +18,9 @@
 //! Autogenerated weights for pallet_frequency_tx_payment
 //!
 //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
-//! DATE: 2023-07-07, STEPS: `20`, REPEAT: `10`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2023-07-11, STEPS: `20`, REPEAT: `10`, LOW RANGE: `[]`, HIGH RANGE: `[]`
 //! WORST CASE MAP SIZE: `1000000`
-//! HOSTNAME: `benchmark-runner-qpqf8-fp5d5`, CPU: `Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz`
+//! HOSTNAME: `benchmark-runner-qpqf8-kk7dv`, CPU: `Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz`
 //! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("frequency-bench"), DB CACHE: 1024
 
 // Executed Command:
@@ -61,18 +61,18 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 		// Proof Size summary in bytes:
 		//  Measured:  `0`
 		//  Estimated: `0`
-		// Minimum execution time: 3_613_000 picoseconds.
-		Weight::from_parts(3_860_000, 0)
+		// Minimum execution time: 3_452_000 picoseconds.
+		Weight::from_parts(3_702_000, 0)
 	}
-	/// The range of component `n` is `[0, 2]`.
+	/// The range of component `n` is `[0, 10]`.
 	fn pay_with_capacity_batch_all(n: u32, ) -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `0`
 		//  Estimated: `0`
-		// Minimum execution time: 7_348_000 picoseconds.
-		Weight::from_parts(7_847_302, 0)
-			// Standard Error: 38_669
-			.saturating_add(Weight::from_parts(5_599_192, 0).saturating_mul(n.into()))
+		// Minimum execution time: 7_291_000 picoseconds.
+		Weight::from_parts(8_383_841, 0)
+			// Standard Error: 11_802
+			.saturating_add(Weight::from_parts(4_916_922, 0).saturating_mul(n.into()))
 	}
 }
 
@@ -82,17 +82,17 @@ impl WeightInfo for () {
 		// Proof Size summary in bytes:
 		//  Measured:  `0`
 		//  Estimated: `0`
-		// Minimum execution time: 3_613_000 picoseconds.
-		Weight::from_parts(3_860_000, 0)
+		// Minimum execution time: 3_452_000 picoseconds.
+		Weight::from_parts(3_702_000, 0)
 	}
-	/// The range of component `n` is `[0, 2]`.
+	/// The range of component `n` is `[0, 10]`.
 	fn pay_with_capacity_batch_all(n: u32, ) -> Weight {
 		// Proof Size summary in bytes:
 		//  Measured:  `0`
 		//  Estimated: `0`
-		// Minimum execution time: 7_348_000 picoseconds.
-		Weight::from_parts(7_847_302, 0)
-			// Standard Error: 38_669
-			.saturating_add(Weight::from_parts(5_599_192, 0).saturating_mul(n.into()))
+		// Minimum execution time: 7_291_000 picoseconds.
+		Weight::from_parts(8_383_841, 0)
+			// Standard Error: 11_802
+			.saturating_add(Weight::from_parts(4_916_922, 0).saturating_mul(n.into()))
 	}
 }

runtime/common/src/constants.rs

@@ -225,7 +225,7 @@ pub type TransactionByteFee = ConstU128<{ 10 * currency::MILLICENTS }>;
 // -end- Transaction Payment Pallet ---
 
 // --- Frequency Transaction Payment Pallet ---
-pub type MaximumCapacityBatchLength = ConstU8<2>;
+pub type MaximumCapacityBatchLength = ConstU8<10>;
 // -end- Frequency Transaction Payment Pallet ---
 
 // --- Session Pallet ---

runtime/frequency/src/lib.rs

@@ -249,7 +249,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: create_runtime_str!("frequency"),
 	impl_name: create_runtime_str!("frequency"),
 	authoring_version: 1,
-	spec_version: 43,
+	spec_version: 44,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,
@@ -263,7 +263,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
 	spec_name: create_runtime_str!("frequency-rococo"),
 	impl_name: create_runtime_str!("frequency"),
 	authoring_version: 1,
-	spec_version: 43,
+	spec_version: 44,
 	impl_version: 0,
 	apis: RUNTIME_API_VERSIONS,
 	transaction_version: 1,