Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is AndroidDevMetrics compatible with Dagger 1?? #40

Open
JSBerrocoso opened this issue Feb 1, 2018 · 2 comments
Open

Is AndroidDevMetrics compatible with Dagger 1?? #40

JSBerrocoso opened this issue Feb 1, 2018 · 2 comments

Comments

@JSBerrocoso
Copy link

Is AndroidDevMetrics compatible with Dagger 1??

@skrzyneckik
Copy link
Contributor

@JSBerrocoso in Readme only Dagger 2 is mentioned, but I was curious what is this plugin behaviour with Dagger 1, so I've checked it with Jake Wharton u2020 project (my fork with the plugin integrated) and actually I was positively surprised - it displays metrics for Dagger 1 graph creation without any problems. So I think it's safe to say "AndroidDevMetrics plugin works with Dagger 1, but it isn't officially supported".

@frogermcs do you have anything to add?

@frogermcs
Copy link
Owner

I have never checked this because I used Dagger 1 not so much. Not sure if there are any advantages of using v1 instead of v2 (except maintaining the old code). I would keep recommending transition from Dagger 1 to Dagger 2 instead of providing backward comoatibilty.
But if it just works, that's great! I guess it's simply because APIs of both frameworks are really close to each other when it comes to graph creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants