Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli | esbuild exclude flag #85

Open
cjenaro opened this issue Jun 15, 2021 · 2 comments
Open

cli | esbuild exclude flag #85

cjenaro opened this issue Jun 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@cjenaro
Copy link

cjenaro commented Jun 15, 2021

It'd be nice if we could pass down flags to the cli and then into the esbuild buildSync function, more particularly I ran into an issue with a module I needed to exclude.

@cjenaro
Copy link
Author

cjenaro commented Jun 15, 2021

I added a preliminary PR of what could be, maybe we could add some of the other options and also the config file

@estrattonbailey
Copy link
Member

Small note we talked about in Discord: wondering if exclude is a confusing name in this case.

presta watched pages/Home.js pages/Posts.jsx pages/AnotherPage.tsx --exclude=prisma

It might appear to maybe exclude prisma from being watched or something? Maybe it should be more specific, like --esbuild-exclude or something. Just spitballing here.

We should also support presta.config.js options for the esbuild compilation. Maybe we should only support config file? That way we can skip having to parse esbuild options in addition to our own 🤔

@estrattonbailey estrattonbailey added the enhancement New feature or request label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants