Linting and Colorization

[nosami]

I noticed that linting and colorization are supported by fsautocomplete. Do you want PRs for these?

[rneatherway]

That would be great :-).

1. Linting. I would probably leave this off by default so as not to surprise people.
2. Colorization. It is only the very basic extended information about new computation expressions, as far as I know. You can see what it gives in the corresponding FSAC test. I think the easiest place to hook it in, if you think it is worthwhile, would be to make this function aware of some variable https://github.com/fsharp/emacs-fsharp-mode/blob/master/fsharp-mode-font.el#L216. You can see from the string case that you can do arbitrary processing, so checking a pre-populated variable should be easy.

[nosami]

For linting, I was thinking it might be a good idea to integrate it with flycheck.

Could do the same for compiler errors too.

[rneatherway]

For linting, I was thinking it might be a good idea to integrate it with flycheck.

I'm not intrinsically against it, but what are the benefits compared to the current approach?

[nosami]

The error list can be useful and it has plugins for most languages. It's very widely used.

Also, using that would probably cut down the amount of code in emacs-fsharp-mode.

[rneatherway]

Also, using that would probably cut down the amount of code in emacs-fsharp-mode.

That's reason enough :-)

Sure I would accept a PR on that basis.

[delexi]

If possible flycheck is definitely the way to go here.

[nosami]

Just wanted to say that I've not forgotten about this. I got linting working pretty quickly but hit a bug where it was linting continuously (even while not typing) and just not had chance to go back and fix it yet.

[rneatherway]

Cool that's looking really nice!

[delexi]

@nosami Which theme is this?

[nosami]

@delexi it's gruvbox

[juergenhoetzel]

👍 for flycheck @nosami Do you have an up2date branch of your work I can try?

[nosami]

@juergenhoetzel Not up to date, but it's here https://github.com/nosami/emacs-fsharp-mode. Sorry, not had any time!

[juergenhoetzel]

Thanks. I will give it a try.