diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Append.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Append.Tests.fs index 32010192..eec1fe99 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Append.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Append.Tests.fs @@ -95,6 +95,7 @@ module SideEffects = [)>] let ``TaskSeq-appendSeq consumes whole sequence once incl after-effects`` variant = + // TODO use variant let mutable i = 0 let ts = taskSeq { @@ -110,6 +111,7 @@ module SideEffects = [)>] let ``TaskSeq-prependSeq consumes whole sequence once incl after-effects`` variant = + // TODO use variant let mutable i = 0 taskSeq { diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Except.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Except.Tests.fs index db49b2c0..5df3da4b 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Except.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Except.Tests.fs @@ -52,6 +52,7 @@ module EmptySeq = [)>] let ``TaskSeq-except no side effect in exclude seq if source seq is empty`` variant = + // TODO use variant let mutable i = 0 let exclude = taskSeq { @@ -98,6 +99,7 @@ module Immutable = [)>] let ``TaskSeq-exceptOfSeq removes duplicates`` variant = + // TODO use variant TaskSeq.ofList [ 1; 1; 2; 3; 4; 12; 12; 12; 13; 13; 13; 13; 13; 99 ] |> TaskSeq.exceptOfSeq [ 1..10 ] |> TaskSeq.toArrayAsync diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Pick.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Pick.Tests.fs index e03c236b..7ba4b361 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Pick.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Pick.Tests.fs @@ -128,6 +128,7 @@ module Immutable = [)>] let ``TaskSeq-pick happy path first item of seq`` variant = task { + // TODO use variant let! first = Gen.sideEffectTaskSeqMicro 50L<µs> 1000L<µs> 50 |> TaskSeq.pick (fun x -> if x = 1 then Some $"first{x}" else None) // dummy tasks seq starts at 1 diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Realworld.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Realworld.fs index f7c8594f..2860f3b0 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.Realworld.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.Realworld.fs @@ -44,8 +44,6 @@ type AsyncBufferedReader(output: ITestOutputHelper, data, blockSize) = let! bytesRead = buffered.ReadAsync(mem, 0, mem.Length) // offset refers to offset in target buffer, not source lastPos <- buffered.Position - let x: seq = seq { 1 } |> Seq.cast - if bytesRead > 0 then current <- ValueSome mem return true @@ -102,20 +100,9 @@ type ``Real world tests``(output: ITestOutputHelper) = [] let ``Reading a 10MB buffered IAsync stream from start to finish`` () = task { - let mutable count = 0 use reader = AsyncBufferedReader(output, Array.init 2048 byte, 256) let expected = Array.init 256 byte - let ts = taskSeq { - for data in reader do - do count <- count + 1 - - if count > 40960 then - failwith "Too far!!!!!!" // ensuring we don't end up in an endless loop - - yield data - } - // the following is extremely slow, which is why we just use F#'s comparison instead // Using this takes 67s, compared to 0.25s using normal F# comparison. // reader |> TaskSeq.toArray |> should equal expected // VERY SLOW!! diff --git a/src/FSharp.Control.TaskSeq.Test/TaskSeq.ToXXX.Tests.fs b/src/FSharp.Control.TaskSeq.Test/TaskSeq.ToXXX.Tests.fs index 082fe98d..306dcbde 100644 --- a/src/FSharp.Control.TaskSeq.Test/TaskSeq.ToXXX.Tests.fs +++ b/src/FSharp.Control.TaskSeq.Test/TaskSeq.ToXXX.Tests.fs @@ -138,6 +138,7 @@ module SideEffects = [)>] let ``TaskSeq-toListAsync should execute side effects multiple times`` variant = task { + // TODO use variant let tq = Gen.sideEffectTaskSeq 10 let! (results1: list<_>) = tq |> TaskSeq.toListAsync let! (results2: list<_>) = tq |> TaskSeq.toListAsync