Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign to match f# naming conventions #375

Open
wallymathieu opened this issue Aug 30, 2019 · 3 comments
Open

Redesign to match f# naming conventions #375

wallymathieu opened this issue Aug 30, 2019 · 3 comments

Comments

@wallymathieu
Copy link
Member

wallymathieu commented Aug 30, 2019

Description

FSharpx provides a lot of functionality, but there is some need to trim it and apply .net and f# naming conventions.

See also:
#311
#325
#368

Some of the modules clashes with System types and causes problems for c#.

Repro steps

Note for instance that the following does not compile:

String.Join(" ",Strings.splitBy(c=>c== '?' || c=='!', "Hello?World?fsharpx"));

Expected behavior

Following how it's done in f# core, I would expect the below to compile:

String.Join(" ",Strings.SplitBy(c=>c== '?' || c=='!', "Hello?World?fsharpx"));

It could also be nice to be able to do the following:

Enums.TryParse<LanguageOptions>("English")

Lenses are useful in c# as well. Being able to create and compose f#x lenses would be a nice thing.

Some of the modules could simply be pluralized in order to avoid c# type system issues.

@wallymathieu
Copy link
Member Author

Anything I've missed @smoothdeveloper?

@wallymathieu
Copy link
Member Author

Ping @panesofglass

@gdziadkiewicz
Copy link
Collaborator

IMO it would be a good idea to decide on a solution, implement it and release in 3.0.0 if breaking changes will be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants