Group conditions for dotnet sdk projects #2394

TheAngryByrd · 2017-06-05T21:40:29Z

Description

I'm trying to move this type of code to from nuget to paket

  <ItemGroup Condition="'$(TargetFramework)'=='net45'">
    <PackageReference Include="FSharp.Core" Version="4.0.0.*" />
  </ItemGroup>
  <ItemGroup Condition="'$(TargetFramework)'=='netstandard1.6'">
    <PackageReference Include="FSharp.Core" Version="4.1.*" />
  </ItemGroup>

However when I move to setup below I get this error and similar (truncated since it's very long)

/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error : Package System.Globalization.Calendars 4.3.0 is not compatible with net45 (.NETFramework,Version=v4.5). Package System.Globalization.Calendars 4.3.0 supports: [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - monoandroid10 (MonoAndroid,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - monotouch10 (MonoTouch,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - net46 (.NETFramework,Version=v4.6) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - netstandard1.3 (.NETStandard,Version=v1.3) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinios10 (Xamarin.iOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinmac20 (Xamarin.Mac,Version=v2.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarintvos10 (Xamarin.TVOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinwatchos10 (Xamarin.WatchOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]

Repro steps

paket.dependencies

group full
    condition: FULL
    framework: net45
    source https://www.nuget.org/api/v2
    nuget FSharp.Core 4.0.0.1
group core
    condition: CORE
    framework: netstandard1.6
    source https://www.nuget.org/api/v2
    nuget FSharp.Core 4.1.17

paket.references

group core
FSharp.Core
group full
FSharp.Core

fsproj

<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFrameworks>netstandard1.6;net45</TargetFrameworks>
  </PropertyGroup>
  <PropertyGroup Condition="'$(TargetFramework)'=='net45'">
     <FULL>true</FULL>
  </PropertyGroup>
  <PropertyGroup Condition="'$(TargetFramework)'=='netstandard1.6'">
    <CORE>true</CORE>
  </PropertyGroup>
  <ItemGroup>
    <Compile Include="Library.fs" />
  </ItemGroup>
  <ItemGroup>
    <PackageReference Include="FSharp.NET.Sdk" Version="1.0.*" PrivateAssets="All" />
  </ItemGroup>
  <Import Project="..\..\.paket\Paket.Restore.targets" />
</Project>

Then run dotnet restore on src\MyLib

https://github.com/TheAngryByrd/paketConditonNetcore

Expected behavior

Ability to restore and build net45 and netstandard1.6 with different versions of FSharp.Core

Actual behavior

/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error : Package System.Globalization.Calendars 4.3.0 is not compatible with net45 (.NETFramework,Version=v4.5). Package System.Globalization.Calendars 4.3.0 supports: [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - monoandroid10 (MonoAndroid,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - monotouch10 (MonoTouch,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - net46 (.NETFramework,Version=v4.6) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - netstandard1.3 (.NETStandard,Version=v1.3) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinios10 (Xamarin.iOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinmac20 (Xamarin.Mac,Version=v2.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarintvos10 (Xamarin.TVOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]
/usr/local/share/dotnet/sdk/1.0.1/NuGet.targets(97,5): error :   - xamarinwatchos10 (Xamarin.WatchOS,Version=v1.0) [/Users/jimmybyrd/Documents/GitHub/classLibTemplate/Content/src/MyLib/MyLib.fsproj]

Known workarounds

Use nuget 😭

Version info

Mono JIT compiler version 4.8.1 (mono-4.8.0-branch/22a39d7

.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.11
 OS Platform: Darwin
 RID:         osx.10.11-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.1

Paket version 5.0.0-beta010

The text was updated successfully, but these errors were encountered:

TheAngryByrd · 2017-06-05T21:49:43Z

Well I guess I want to end up with this as my dependency tree on nuget when I go to pack it

Dependencies
.NETFramework 4.5
FSharp.Core (>= 4.0.0.1)
.NETStandard 1.6
FSharp.Core (>= 4.1.2)
NETStandard.Library (>= 1.6.1)

If someone is consuming my lib on net45, i don't want to force them to update their FSharp.Core dependency

matthid · 2017-06-05T22:57:02Z

@baronfel Doing something like this is messy one way or another.

You can cheat and just edit the deps of the resulting package
-> You don't actually know if you are still compatible with the older package.
You use conditions and multiple groups
-> You need to do a lot on your own (I'm not even sure how pack currently handles that)
-> On the other side you actually test that everything works for users of your nuget package.

enricosada · 2018-01-24T16:25:16Z

from #2612 (comment) by @yevhen

In a mixed solution where some of the projects use new VS17 csproj format and target multiple frameworks (net462/nestandard) conditional references are required for some scenarios, such as referencing System.AppDomain for netstandard but not when building for net46.

Example:

<ItemGroup>
  <PackageReference Include="System.AppDomain" Version="2.0.11"
                    Condition="'$(TargetFrameworkIdentifier)' == '.NETStandard'" />
</ItemGroup>

TheAngryByrd · 2020-03-26T19:56:36Z

As .net 5 is the way forward, I'm gonna close this.

older · 2020-04-16T14:49:53Z

As .net 5 is the way forward, I'm gonna close this.

@TheAngryByrd Does it mean that it is not going to be possible until .NET 5 is released? How would .NET 5 help with this?

TheAngryByrd · 2020-04-16T17:37:24Z

Everything is going to be .NET 5. There won't really be a .NET core or .NET framework.

older · 2020-04-17T13:20:58Z

Everything is going to be .NET 5. There won't really be a .NET core or .NET framework.

.NET framework will be supported by Microsoft so long Windows variants (with .NET included) are supported. So this problem will still be unsolvable with paket if you need to support both .NET 4 and .NET 5 in your code.

TheAngryByrd · 2020-04-17T14:21:28Z

I'm not concerned with supporting super old versions of frameworks. This post covers some similar thoughts I have about supporting older frameworks.

cdrnet · 2020-04-17T16:12:00Z

I'm not concerned with supporting super old versions of frameworks.

I hope this doesn't reflect the general consensus here. .NET 5 doesn't replace anything, it's just one more on top. .NET Framework and .NET Core are not going away ...

older · 2020-04-20T12:06:11Z

I'm not concerned with supporting super old versions of frameworks.

I'm sure you don't, but paket as a project did not declare that it's abandoning all versions except .NET 5, so this issue in paket still stands and therefore it should not be closed?

forki · 2020-04-23T07:09:46Z

we will continue to support old frameworks as good as we as a community can.

older · 2020-04-27T10:41:13Z

we will continue to support old frameworks as good as we as a community can.

@forki So shouldn't this issue be reopened then?

Shmew · 2020-11-19T21:43:21Z

I ran into this issue since some libraries only target net5.0 or netcoreapp3.1.

It took me a while to figure this out as it doesn't seem to be documented, but I was eventually able to get conditions working so that it would reference the proper package based on the targeted framework.

paket.dependencies:

group Net5
    source https://nuget.org/api/v2
    source https://api.nuget.org/v3/index.json
    
    condition: net5_0
    framework: net5
    
    ...
    nuget Microsoft.AspNetCore.Authentication.JwtBearer ~> 5


group NetCoreApp3
    source https://nuget.org/api/v2
    source https://api.nuget.org/v3/index.json
    
    condition: netcoreapp3_1
    framework: netcoreapp3.1
    
    ...
    nuget Microsoft.AspNetCore.Authentication.JwtBearer ~> 3

paket.references:

group NetCoreApp3
    ...
    Microsoft.AspNetCore.Authentication.JwtBearer

group Net5
    ...
    Microsoft.AspNetCore.Authentication.JwtBearer

I haven't really dug too deep into the source code, but I suspect that condition needs to be a platform as opposed to something defined in your fsproj.

older · 2020-11-23T09:43:19Z

package.dependencies:

Shouldn't this be paket.dependencies ?

I haven't really dug too deep into the source code, but I suspect that condition needs to be a platform as opposed to something defined in your fsproj.

Looks like preprocessor symbols? But I couldn't even find documentation on condition syntax.

Shmew · 2020-11-23T15:39:21Z

Shouldn't this be paket.dependencies ?

Yes, that was a typo on my part! I fixed it.

Looks like preprocessor symbols? But I couldn't even find documentation on condition syntax.

Yes, it doesn't seem to be documented at all. I figured this out by spending a bunch of time digging through the paket code and ancient issues 😅.

older · 2020-11-24T07:52:08Z

@forki could you comment on this? Is this something which should be documented here?

anpin · 2023-06-20T05:14:52Z

Thank you @Shmew for the solution! I've found that order of targets in the project file matters, meaning [1] fails to resolve proper package, but [2] works as expected
[1] <TargetFrameworks>net6.0;netstandard2.0</TargetFrameworks>
[2] <TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>

romerod · 2024-10-10T05:33:37Z

Also conditions on dependencies do not work right?

Is someone working on this?

This comment has been minimized.

Sign in to view

bhugot mentioned this issue Jun 16, 2017

Implementation for #913 Paket.pack: add support for nuget dependencies conditional on target framework #2428

Merged

TheAngryByrd mentioned this issue Aug 31, 2017

Conditional package references #2612

Closed

enricosada added the sdk: dotnet/sdk label Jan 23, 2018

enricosada changed the title ~~Group conditions for netcore projects~~ Group conditions for dotnet sdk projects Jan 23, 2018

enricosada mentioned this issue Jan 24, 2018

NewSdk and MultiTargeting and Conditions #2596

Closed

enricosada added the enhancement label Jan 24, 2018

enricosada assigned enricosada and unassigned enricosada Jan 24, 2018

samhanes mentioned this issue Nov 3, 2018

Target Netstandard 2.0 fsprojects/FSharp.Data.SqlClient#314

Merged

TheAngryByrd closed this as completed Mar 26, 2020

forki reopened this Apr 27, 2020

vgeronimos linked a pull request Feb 15, 2024 that will close this issue

Implement group conditions for SDK-style projects #4247

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Group conditions for dotnet sdk projects #2394

Group conditions for dotnet sdk projects #2394

TheAngryByrd commented Jun 5, 2017 •

edited by enricosada

Loading

This comment has been minimized.

TheAngryByrd commented Jun 5, 2017 •

edited

Loading

matthid commented Jun 5, 2017

enricosada commented Jan 24, 2018

TheAngryByrd commented Mar 26, 2020

older commented Apr 16, 2020 •

edited

Loading

TheAngryByrd commented Apr 16, 2020

older commented Apr 17, 2020

TheAngryByrd commented Apr 17, 2020

cdrnet commented Apr 17, 2020 •

edited

Loading

older commented Apr 20, 2020

forki commented Apr 23, 2020

older commented Apr 27, 2020

Shmew commented Nov 19, 2020 •

edited

Loading

older commented Nov 23, 2020

Shmew commented Nov 23, 2020

older commented Nov 24, 2020

anpin commented Jun 20, 2023

romerod commented Oct 10, 2024

Group conditions for dotnet sdk projects #2394

Group conditions for dotnet sdk projects #2394

Comments

TheAngryByrd commented Jun 5, 2017 • edited by enricosada Loading

Description

Repro steps

Expected behavior

Actual behavior

Known workarounds

Version info

This comment has been minimized.

TheAngryByrd commented Jun 5, 2017 • edited Loading

matthid commented Jun 5, 2017

enricosada commented Jan 24, 2018

TheAngryByrd commented Mar 26, 2020

older commented Apr 16, 2020 • edited Loading

TheAngryByrd commented Apr 16, 2020

older commented Apr 17, 2020

TheAngryByrd commented Apr 17, 2020

cdrnet commented Apr 17, 2020 • edited Loading

older commented Apr 20, 2020

forki commented Apr 23, 2020

older commented Apr 27, 2020

Shmew commented Nov 19, 2020 • edited Loading

older commented Nov 23, 2020

Shmew commented Nov 23, 2020

older commented Nov 24, 2020

anpin commented Jun 20, 2023

romerod commented Oct 10, 2024

TheAngryByrd commented Jun 5, 2017 •

edited by enricosada

Loading

TheAngryByrd commented Jun 5, 2017 •

edited

Loading

older commented Apr 16, 2020 •

edited

Loading

cdrnet commented Apr 17, 2020 •

edited

Loading

Shmew commented Nov 19, 2020 •

edited

Loading