Skip to content

Post-triage footer should suppress /fs-code when triage flags requires_workflow_changes #774

Description

@fullsend-ai-retro

What happened

On issue #50, the triage agent (run 31484207332) correctly identified that the fix required modifying .github/workflows/site-build.yml and warned: "The code agent cannot modify workflow files under current permissions." However, the post-triage script's "Next steps" footer unconditionally appended /fs-code as an option directly below this warning. The user invoked /fs-code, triggering a code agent run (run 31484740965) that ran for 251 seconds, generated the correct fix (exit code 0), but failed at push time because the GitHub App token lacks workflows permission.

What could go better

The post-triage footer in scripts/post-triage.sh unconditionally suggests /fs-code for all issues with a sufficient triage verdict. Existing issue agents#460 proposes making this footer conditional on whether the repo has a code agent configured, but that check alone would not have prevented this case — the repo does have a code agent; the issue is that this specific fix requires workflow file changes the code agent cannot push. The footer should also be conditioned on issue-specific triage signals like requires_workflow_changes. This is a high-confidence finding: the contradictory messaging (warning + /fs-code suggestion) directly preceded the user invoking /fs-code and triggering the wasted run.

Proposed change

In scripts/post-triage.sh, extend the sufficient footer logic to parse the triage agent's structured output for signals indicating the code agent cannot handle the fix (e.g., requires_workflow_changes: true or similar markers). When such a signal is detected, suppress the /fs-code suggestion and instead display a message like: "This issue requires changes the code agent cannot push (e.g., workflow files). A manual PR or maintainer action is needed." This extends the conditional footer logic proposed in agents#460 from repo-level config checks to issue-specific triage signal checks.

Validation criteria

On the next issue where the triage agent identifies requires_workflow_changes (or equivalent signal), the post-triage comment's "Next steps" section should NOT include /fs-code as an option, and should instead direct the user toward manual action. Verify on at least 2 such issues across different repos.


Generated by retro agent from fullsend-ai/experiments#51

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions