chore: deduplicate harness config across forge sections

[ggallen]

Summary

PR #817 (retro multi-forge) established a clean pattern: define shared config at the top level and only put forge-specific overrides in forge.<platform> sections. The harness runtime's mergeForgeConfig confirms this is safe — scalars only override when non-empty, and env maps merge with forge keys winning on collision.

Three other harness files have redundant duplication that can be cleaned up the same way.

What to change

harness/code.yaml

Remove duplicate scalars (identical to top-level):

• forge.github.pre_script (line 78) — duplicates top-level line 44
• forge.github.post_script (line 79) — duplicates top-level line 45
• forge.gitlab.pre_script (line 107) — duplicates top-level line 44
• forge.gitlab.post_script (line 108) — duplicates top-level line 45

Hoist common env.runner keys to top-level env.runner:

• PUSH_TOKEN: "${PUSH_TOKEN}" (github:88, gitlab:116)
• PUSH_TOKEN_SOURCE: "${PUSH_TOKEN_SOURCE}" (github:89, gitlab:117)
• REPO_FULL_NAME: "${REPO_FULL_NAME}" (github:90, gitlab:118)
• ISSUE_NUMBER: "${ISSUE_NUMBER}" (github:91, gitlab:119)

Hoist common env.sandbox keys to top-level env.sandbox:

• GIT_AUTHOR_NAME: "fullsend-code" (github:100, gitlab:128)
• GIT_AUTHOR_EMAIL: "${GIT_BOT_EMAIL}" (github:101, gitlab:129)
• GIT_COMMITTER_NAME: "fullsend-code" (github:102, gitlab:130)
• GIT_COMMITTER_EMAIL: "${GIT_BOT_EMAIL}" (github:103, gitlab:131)

harness/triage.yaml

Remove duplicate scalars (identical to top-level):

• forge.github.pre_script (line 48) — duplicates top-level line 26
• forge.github.post_script (line 49) — duplicates top-level line 27
• forge.gitlab.pre_script (line 68) — duplicates top-level line 26
• forge.gitlab.post_script (line 69) — duplicates top-level line 27
• forge.jira.pre_script (line 88) — duplicates top-level line 26
• forge.jira.post_script (line 89) — duplicates top-level line 27

harness/review.yaml

Hoist pre/post scripts to top-level (identical in both forge sections, currently missing from top-level):

• pre_script: scripts/pre-review.sh (github:64, gitlab:92)
• post_script: scripts/post-review.sh (github:65, gitlab:93)

Hoist common env.runner keys to top-level env.runner:

• REPO_FULL_NAME: "${REPO_FULL_NAME}" (github:78, gitlab:105)

Hoist common env.sandbox keys to top-level env.sandbox:

• REPO_FULL_NAME: "${REPO_FULL_NAME}" (github:83, gitlab:111)
• PRIOR_REVIEW_SHA: "${PRIOR_REVIEW_SHA}" (github:88, gitlab:116)
• PRIOR_REVIEW_PROVENANCE: "${PRIOR_REVIEW_PROVENANCE}" (github:89, gitlab:117)

Not in scope

• harness/prioritize.yaml — already follows the clean pattern
• harness/retro.yaml — cleaned up in feat(#816): make retro agent multi-forge (GitHub + GitLab) #817

Why this is safe

mergeForgeConfig in internal/harness/forge.go (lines 162–218) merges forge sections into the top-level harness:

• Scalars (pre_script, post_script, policy): forge overrides only if non-empty; top-level value is preserved otherwise
• Env maps: top-level merged with forge; forge keys win on collision

All values listed above are identical across every forge section in their respective file. Moving them to the top level produces the same resolved config.

Line numbers

Based on commit 0a5599e (current main).

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 8:09 PM UTC · Completed 8:13 PM UTC

Commit: 0a5599e · View workflow run →

[fullsend-ai-triage]

Verified all duplication claims against the codebase at 0a5599e — every item checks out.

Net-new observations

• retro.yaml still has the same duplication (top-level pre_script/post_script repeated in forge.github), but the issue correctly scopes it out since PR feat(#816): make retro agent multi-forge (GitHub + GitLab) #817 handles that file.
• prioritize.yaml does not have top-level pre_script/post_script repeated in forge sections — confirmed already clean, consistent with the issue's exclusion.
• No merge-conflict risk with feat(#816): make retro agent multi-forge (GitHub + GitLab) #817 — the two efforts touch disjoint files (retro.yaml vs code/triage/review.yaml).

Proposed test

For each modified file (code.yaml, triage.yaml, review.yaml):
  For each forge platform (github, gitlab, jira where applicable):
    1. Compute resolved config BEFORE the change (mergeForgeConfig output)
    2. Compute resolved config AFTER the change
    3. Assert the two resolved configs are byte-identical
    4. Spot-check that forge-specific keys NOT hoisted
       (ISSUE_URL, GH_TOKEN, GITLAB_TOKEN, FULLSEND_FORGE, etc.)
       still resolve to their per-forge values

---

Next steps:

• /fs-code — agent creates a PR to implement this issue
• /fs-code <your instruction> — agent implements with your specific guidance

[ggallen]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 9:26 PM UTC · Completed 9:36 PM UTC

Commit: 2c3e23f · View workflow run →